Comments (2)
Thank you @gcox for raising this issue! I just checked it on iPhone X and you're right it's not being positioned properly, I'll look into it as soon as possible.
from mspeekcollectionviewdelegateimplementation.
Hello @gcox ! Apologies it's been a while since I got back to you. I've been looking into this and it feels that this problem is related to any flow layout not just this implementation. Also, this implementation doesn't know the hierarchy outside its collection view, and I think it's better this way. Otherwise, this implementation would be doing too much and it defies the separation of concerns concept. I understand that you don't want to implement this in the view controller to avoid the repetition of code, but we might be able to create an extension for UIViewController which fixes this problem and we can use that instead. Either ways, it's something we can do for a regular collection view also to avoid having the cells span behind the notch.
Let me know your thoughts about that 👍
from mspeekcollectionviewdelegateimplementation.
Related Issues (20)
- Scrolling with 0 velocity will not land on the correct page HOT 11
- Add support to animate peeking items while scrolling HOT 1
- Where is MSPeekImplementationDelegate now? HOT 3
- Add SPM Support HOT 2
- Alignment horizontal scroll collection view HOT 6
- Is it possible to change the view content of center one? HOT 3
- RxCollectionView only shows one cell always HOT 1
- sizeForItem delegate function is not called when peek behavior is configured HOT 6
- Use of undeclared type 'MSCollectionViewPeekingBehavior' HOT 4
- Use of undeclared type 'MSCollectionViewPeekingBehavior' HOT 1
- extra space !? HOT 4
- MSPeekImplementationDelegate returns under/over index in race conditions HOT 5
- Top and Bottom spacing of UICollectionViewCell cut HOT 2
- Crash on behavior.scrollViewWillEndDragging call in v3.1.1
- Collection view item is getting cut off HOT 8
- SPM Fail HOT 1
- Backward scroll
- Scroll bars not visible
- can't change cell size and positioning
- Mistakenly created
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mspeekcollectionviewdelegateimplementation.