Giter VIP home page Giter VIP logo

Comments (6)

Retttro avatar Retttro commented on June 30, 2024 2

Hi @Earlopain. Thanks for your notes on this issue. I'm planning to make a PR with the transition to Faraday next month. I think we will release this at the end of January.

from mailgun-ruby.

mgrishko avatar mgrishko commented on June 30, 2024 2

@Earlopain over the next 1-2 months, I'll be making these fixes.

from mailgun-ruby.

Earlopain avatar Earlopain commented on June 30, 2024 1

Hi @Retttro / @mgrishko, I'm interested in seeing this resolved. Would you accept a PR switching out rest-client with faraday? There's already a wrapper class around responses with Mailgun::Response so backwards compatibility issues on that front should be minimal, if any.

One somewhat unfortunate consequence of this change is that faraday 2.x requires ruby 2.6 at the minimum and would requires this gem to bump its minimal supported ruby version from 2.2 to 2.6 as well. Ruby 2.5 is EOL since 31 Mar 2021, so almost 3 years now.

Alternatively, I could explore going with plain Net::HTTP which doesn't have this problem. It's not great to use in any way but should get the job done. One sore point in net-http itself is multipart requests (as in no support at all). There's multipart-post but I'd rather not include for this in a gem that others depend on. You get to the situation we are at here where every gem includes different http gems and the consumer suddenly has 10 different ones in their lockfile.

Personally I would much appreciate the possibility of going with faraday just so that I wouldn't have to interact with net-http directly.

from mailgun-ruby.

andreyzhelnin-st avatar andreyzhelnin-st commented on June 30, 2024 1

@Retttro Do you have any updates on this?

from mailgun-ruby.

Earlopain avatar Earlopain commented on June 30, 2024

Thanks for the quick response, I'm looking forward to that (:

from mailgun-ruby.

Earlopain avatar Earlopain commented on June 30, 2024

It looks like Retttro doesn't work for/with mailgun anymore, if LinkedIn is to be believed. @mgrishko, can you give some insight here?

from mailgun-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.