Comments (19)
Ember-simple-auth 6.0.0 released
https://github.com/mainmatter/ember-simple-auth/blob/master/CHANGELOG.md#600-2023-08-18
Sorry for keeping you waiting :)
Feel free to re-open if the is actually not fixed.
from ember-simple-auth.
I can confirm that 6.0.0-rc.1 works fine. Looking forward to the release.
from ember-simple-auth.
I'm getting "Could not find module ember-simple-auth/services/session
imported from (require)
" when using "6.0.0-rc.1".
This is with Ember 5 and embroider.
from ember-simple-auth.
Hi @BobrImperator, Do you know when 6.0.0 will be released ?
from ember-simple-auth.
Please use 6.0.0-rc.1
version.
It should be fairly safe to use and soon we'll do an official 6.0.0
release.
I don't expect any library changes between the release candidate and 6.0.0
either.
from ember-simple-auth.
Link to the changelog https://github.com/mainmatter/ember-simple-auth/releases/tag/6.0.0-rc.1
from ember-simple-auth.
Hi @bracke
Are you using Torii by any chance?
We've had failing embroider + ember-source 5 scenarios when torii is present. See #2559
from ember-simple-auth.
@BobrImperator No, not in this project.
Anything I can do to locate the cause?
from ember-simple-auth.
@bracke It's a tricky issue.
Usually I'd find it to be a mixture of outdated addons and ember's build dependencies ember-cli-babel
, ember-auto-import
, ember-resolver
.
However it could also be some issue with ESA not being an actual V2 addon.
I'll try to give it a shot later this week and setup a reproduction.
from ember-simple-auth.
@BobrImperator the error happens in our session service when importing the basesessionservice, are we doing anything wrong?
import { service } from '@ember/service';
import BaseSessionService from 'ember-simple-auth/services/session';
export default class SessionService extends BaseSessionService {
@service currentUser;
@service router;
async handleAuthentication() {
super.handleAuthentication(...arguments);
try {
await this.currentUser.load();
} catch (err) {
await this.invalidate();
}
}
}
from ember-simple-auth.
Thanks for the snippet.
It looks OK.
from ember-simple-auth.
@BobrImperator
I have now tried to run our tests and there I get the same problem:
Could not find module
ember-simple-auth/test-supportimported from
(require)``
So the problem is really a general inability to access the 'ember-simple-auth' namespace/folder.
from ember-simple-auth.
Did you get any further? Any idea how we can resolve this?
from ember-simple-auth.
It's very likely it's happening because ESA is still a V1 addon and V1 addons can't be statically analyzed.
WIP #2604
from ember-simple-auth.
I have tried to use the "v2-addon" branch, but it does not seem to make any difference.
I still get "Could not find module ember-simple-auth/services/session
imported from (require)
".
from ember-simple-auth.
The branch might not be functioning properly yet.
Also I've seen on some threads that a lot of folks are downgrading their @embroider deps to 3.0.0
because the current latest 3.1
introduced something that caused breakage:
"@embroider/core": "~3.0.0",
"@embroider/compat": "~3.0.0",
"@embroider/webpack": "~3.0.0",
Like Nullvox proposed to do here https://github.com/mainmatter/ember-simple-auth/pull/2606/files#diff-c88af450d41d3281997faafe7ac13e280ae5840c6b81f68cc395c2a20d7e4830R154
Which didn't actually fix all of our CI but did fix embroider-safe
and embroider-optimized
scenarios for the addon itself.
Both the downgrade and using the specific branch could be worth a shot. If you could try that then that'd help us a lot 👍
Also I'm not sure how installing through git works anymore with the rollup, so please make sure to clone the repo, check out the branch, compile the dist and link ember-simple-auth
from your file system.
from ember-simple-auth.
Still does not seem to change anything.
I have tried all the things you mention.
Note: This is with Ember 5.1.2. and with embroider fully activated.
from ember-simple-auth.
I'm getting ember-cookies errors myself
Build Error (PackagerRunner) in services/cookies.js
Module not found: Error: Can't resolve '/Users/rwwagner90/shipshape/swach/node_modules/.pnpm/[email protected]/node_modules/ember-cookies/services/cookies' in '$TMPDIR/embroider/57a24f/services/cookies.js'
from ember-simple-auth.
Seems that updating embroider fixes that for me.
from ember-simple-auth.
Related Issues (20)
- CookieStore is not initializing/syncing correctly HOT 2
- Dependency Dashboard
- CookieExpirationTime not being set HOT 2
- When syncing tabs (session store), schedule of the refresh token should be updated
- ember-polyfills.deprecate-assign deprication in Ember 4.4 HOT 2
- Action Required: Fix Renovate Configuration
- ESA's Application route hides host app's route when using pod layout & embroider HOT 5
- Access token does not persist HOT 1
- Neither of test apps work - did you stop maintaining it? HOT 1
- Missing deprecation guide for session events HOT 1
- test-app should use modern Octane syntax
- Invalidated immediately after authentication when using cookieStore with Safari HOT 8
- Ember v5 - current ember-canary, ember-beta channels are failing under fastboot HOT 1
- [Embroider] Fails under fastboot in embroider-optimized scenario
- API documentation still at version 5.0.0, but current release is 6.0.0
- this.session.requireAuthentication is returning false on a page refresh, even though user is already authenticated HOT 9
- ember-simple-auth is using its own copies of peer-deps like RSVP HOT 2
- CookieStore SameSite warning in Firefox
- Error: Could not find module `ember-simple-auth after updating to 6.0.0 in a V1 addon HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-simple-auth.