Not compatible with `Vitalize` about majruszlibrary HOT 3 CLOSED

You are right, I replaced that code as it has the exact same meaning but it becomes compatible with Vitalize mod 6d588d2 (it still should be fixed in Vitalize mod to avoid compatibility issues with other mods). Anyway thanks for the report, I will release 4.1.0 version within few days and once it is released I will close this report

from majruszlibrary.

Hi, thanks for the report but I am afraid that there is no reason to fix it in my mod. All parameters are checked before I access them over here:

from majruszlibrary.

Might be to make certain loot drop, not sure

Apotheosis is doing this, had no issues with it so far:
https://github.com/Shadows-of-Fire/Apotheosis/blob/0ad17e2c2b47eb94967e29019c987ddc0d9d240d/src/main/java/shadows/apotheosis/adventure/loot/GemLootPoolEntry.java#L92

See:

public <T> T getParam(LootContextParam<T> lootContextParam) {
    T object = this.params.get(lootContextParam);
    if (object == null) {
        throw new NoSuchElementException(lootContextParam.getName().toString());
    } else {
        return object;
    }
}

@Nullable
public <T> T getParamOrNull(LootContextParam<T> lootContextParam) {
    return this.params.get(lootContextParam);
}

from majruszlibrary.