Giter VIP home page Giter VIP logo

Comments (2)

Majrusz avatar Majrusz commented on September 8, 2024

Hello, OnExperiencePickedUp is called only when the delay is equal to 0 https://github.com/Majrusz/MajruszLibrary/blob/1.20.X/common/src/main/java/com/mlib/mixin/MixinExperienceOrb.java#L25. The inject is before take method:

    public void playerTouch(Player $$0) {
        if (!this.level().isClientSide) {
            if ($$0.takeXpDelay == 0) {
                $$0.takeXpDelay = 2;
                // <-- code was injected here
                $$0.take(this, 1);
                int $$1 = this.repairPlayerItems($$0, this.value);
                if ($$1 > 0) {
                    $$0.giveExperiencePoints($$1);
                }

                --this.count;
                if (this.count == 0) {
                    this.discard();
                }
            }
        }
    }

However you are right, there was a bug that exponentially increased the experience that I fixed here Majrusz/MajruszLibrary@cad9a82. Anyway, thanks for the report!

from majruszsenchantmentsmod.

roobscoob avatar roobscoob commented on September 8, 2024

apologies for the mistake! Hope i didnt lead you down too much of a rabbit hole. Thanks for the patch!

from majruszsenchantmentsmod.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.