patiently retries to few times when Capybara uses its own retry feature about spreewald HOT 4 CLOSED

This sound totally reasonable.

Then again, there is d8b9619, which specifically reverts the exact change you're proposing.

I cannot remember why we had to revert it. I assume it must have something to do with nested patiently blocks, but can't put my finger on it.

Maybe a safeish way would be to change the mechanism to always allow "one more try" after time is up (instead of guaranteeing 2 tries in total)? Of course that might result in slower failures.

from spreewald.

Or, alternatively, we could change it so that

• patiently records the time when the block started
• patiently will retry as long as that timestamp is before the default_wait_time
  @niklas-hasselmeyer do you agree that this would solve your usecase?

from spreewald.

I can imagine that the reason behind d8b9619 was to allow Capybara's own retry feature, which can speed up tests.

When I wrote the issue, I thought that the best fix was to make the two timeouts (Spreewald's and Capybara's) independent. Both of your suggestions sound reasonable, too, and would solve my issue.

from spreewald.

Fix is released as version 4.5.0.

from spreewald.