Giter VIP home page Giter VIP logo

Comments (6)

malchata avatar malchata commented on May 26, 2024 2

Yeah, that's fair. I guess I didn't consider all the use cases around this, and just sort of assumed people npm install it and process their apps using a bundler.

I have a bug that I'm waiting on confirmation for in order to release 3.1.6. I'd be willing to add these files back in on that release.

I'm sorry for the pain this has caused.

from yall.js.

dmnc avatar dmnc commented on May 26, 2024 1

This caught me out too. I was concatenating the yall.min.js directly.

I think the idea of optimising footprint is a noble one, but doing so in a patch version was definitely a surprise.

Given the yall.min.js is less than 2k, this might be trying to optimise a little too far? 😄

from yall.js.

dmnc avatar dmnc commented on May 26, 2024 1

Thank you for such a quick response. I know how hard it can be to work out all your own use cases let alone those other people might come up with!

from yall.js.

malchata avatar malchata commented on May 26, 2024

This was intentional so that the install footprint would be a bit lighter. The reasoning behind it is that package.json only points to ./src/yall.mjs in the module and jsnext:main fields, and the main field points to the CommonJS version at ./dist/yall.js.

Most people will consume yall as an npm package, and process the source with a bundler, and those who want to pluck the minified JS from the repo will probably do so on Github.

I can add these files back in for a future release, but I'm not necessarily convinced it's an issue. But I could be wrong. Let me know your thoughts.

from yall.js.

Spomsoree avatar Spomsoree commented on May 26, 2024

We install our packages via npm and concat them trough gulp to a single minified js file.

We can minify them ourself in this process, so this is not a real problem for us.

from yall.js.

dmnc avatar dmnc commented on May 26, 2024

What's more, this breaks ES5 using npm unless you are already running a transpiler.

When I discovered this problem I attempted to pull in the uncompressed version and uglify, but it is ES6 so uglify falls over. I think I'll have to downgrade for now.

from yall.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.