Broken references when adding to a Unity project about urp-screenspacecavity HOT 11 OPEN

Is there any chance you could post a sample working Unity project?

Or failing that - can you specify which Unity version and URP version is working for you? I'd at least like to recreate as close to your conditions as I can.

(this looks great by the way. thanks for releasing it!)

Effect made and tested on Unity version - 2020.3 URP version - 10.7. Try these versions, everything should work correctly on them or later.

In URP 10, the code for SSAO was added and this effect is written based on it.

from urp-screenspacecavity.

1. Create a new URP project with 2020.3 via Unity Hub
2. Confirm in Package Manager that it is using 10.7
3. Unzip the repo download into Assets

At this point I have an error:

ScreenSpaceCavity_Renderer is missing RendererFeatures
This could be due to missing scripts or compile error.
UnityEngine.Rendering.Universal.ScriptableRendererData:OnValidate () (at Library/PackageCache/[email protected]/Runtime/ScriptableRendererData.cs:59)

Furthermore all the prefab references in the demo scene are broken and the camera has two broken script references on it.

I then look at your original repo and notice there's no .meta files (and no .gitignore either so you must be manually excluding them somehow)

from urp-screenspacecavity.

1. Create a new URP project with 2020.3 via Unity Hub
2. Confirm in Package Manager that it is using 10.7
3. Unzip the repo download into Assets

At this point I have an error:

ScreenSpaceCavity_Renderer is missing RendererFeatures
This could be due to missing scripts or compile error.
UnityEngine.Rendering.Universal.ScriptableRendererData:OnValidate () (at Library/PackageCache/[email protected]/Runtime/ScriptableRendererData.cs:59)

Furthermore all the prefab references in the demo scene are broken and the camera has two broken script references on it.

I then look at your original repo and notice there's no .meta files (and no .gitignore either so you must be manually excluding them somehow)

Of course! Sorry!
Please use the package - https://github.com/malyawka/URP-ScreenSpaceCavity/releases

I rubbed the meta files to make the repository readable.

from urp-screenspacecavity.

I rubbed the meta files to make the repository readable.

I would argue that repo should be functional over readable. ;-)

I'd also like to recommend making the repo an entire working Unity project. If you look around Github for Unity projects you'll find the vast majority of them are packaged as entire projects and there's a good reason for this. In my experience (and I download a lot of Unity code from Github) the chance of something working is significantly higher if it is provided as a project. By all means have a branch that's UPM compatible or supply a .unitypackage under releases. (there's some handy Github actions that automate this for you) but the main repo should be a project.

It makes it much easier for other people to try out your code and generally makes it much more likely that things will just work.

from urp-screenspacecavity.

I rubbed the meta files to make the repository readable.

I would argue that repo should be functional over readable. ;-)

I'd also like to recommend making the repo an entire working Unity project. If you look around Github for Unity projects you'll find the vast majority of them are packaged as entire projects and there's a good reason for this. In my experience (and I download a lot of Unity code from Github) the chance of something working is significantly higher if it is provided as a project. By all means have a branch that's UPM compatible or supply a .unitypackage under releases. (there's some handy Github actions that automate this for you) but the main repo should be a project.

It makes it much easier for other people to try out your code and generally makes it much more likely that things will just work.

You're right. Does the package import result in the effect working as it should?

from urp-screenspacecavity.

You're right. Does the package import result in the effect working as it should?

It's got rid of the errors but I don't see any effect - even when I tick "debug" (which I presume should give me the black and white view)

from urp-screenspacecavity.

I can confirm that the effects don't show up at all even when following the setup instructions to the letter. Unity 2020.3.25f1 + URP 10.7, fresh URP template project with only the Unity package for this installed.

from urp-screenspacecavity.

Also confirming that I do not see the effects at all in the demo scene when following setup instructions, Unity 2021.2.13f1 and URP 12.1.4, all in a fresh URP project.

from urp-screenspacecavity.

I can confirm that the effects don't show up at all even when following the setup instructions to the letter. Unity 2020.3.25f1 + URP 10.7, fresh URP template project with only the Unity package for this installed.

Also confirming that I do not see the effects at all in the demo scene when following setup instructions, Unity 2021.2.13f1 and URP 12.1.4, all in a fresh URP project.

Did you add the renderer feature to the URP forward renderer in the settings? Out of the box it will also only work with the example ToonyShader

from urp-screenspacecavity.

Did you add the renderer feature to the URP forward renderer in the settings? Out of the box it will also only work with the example ToonyShader

Yes, in a blank URP project, after importing, I have the project set to use the URP asset and Universal Renderer Data asset which are included in PolgonStarter/URP/, and those have the renderer feature applied.

from urp-screenspacecavity.

I can confirm that the effects don't show up at all even when following the setup instructions to the letter. Unity 2020.3.25f1 + URP 10.7, fresh URP template project with only the Unity package for this installed.

Also confirming that I do not see the effects at all in the demo scene when following setup instructions, Unity 2021.2.13f1 and URP 12.1.4, all in a fresh URP project.

Did you add the renderer feature to the URP forward renderer in the settings? Out of the box it will also only work with the example ToonyShader

Yes. I opened the example scene provided after ensuring the renderer feature was set up correctly, and all of the materials in that example scene were using the shader you referenced. There is no cavity/edge effect whatsoever.

from urp-screenspacecavity.