Bar Button Items in Navigation Bar loose textcolor after modal view did cover them about mathemekit HOT 8 CLOSED

I've tried to replicate this programmatically by presenting a modal view controller, but it works fine for me. Perhaps this is a segue/storyboard issue?

https://www.dropbox.com/s/u3obaxwhj1b2bb2/nav%20item.mov?dl=0

from mathemekit.

The issue only happens when using a text button bar item, not with system or image bar button items.
It is not storyboard related, tested it by adding a modal view to your demo project and adding a dismiss programmatically. Same effect!

https://www.dropbox.com/s/ycbah06bz8sctj5/MAThemeIssueDemo.mp4?dl=0

from mathemekit.

Ahh indeed.. Very weird. At first glance this looks like an OS bug, as my code isn't doing anything after viewDidLoad, so perhaps there's a bug in the appearance proxy methods.

from mathemekit.

Just found and fixed it!
The Button Appearance is set to the primary color.
It helps when I add this to the code:

#pragma mark - UI Navigation Bar Button
+(void)customizeNavigationBarButtonColor:(UIColor *)buttonColor {
[[UIButton appearanceWhenContainedIn:[UINavigationBar class], nil] setTitleColor:buttonColor forState:UIControlStateNormal];
}

And in the method setupThemeWithPrimaryColor add this line after customizeNavigationBarColor:
[self customizeNavigationBarButtonColor:secondaryColor];

Text now also gets the textcolor when the button is contained in a UINavigationBar, even after being covered by a modal screen. Yay!

from mathemekit.

Very weird, thanks for that, I'll incorporate the fix in a moment.. It does seem to be an OS bug, in that you need to set both the line you added above as well as [[UINavigationBar appearance] setTintColor:buttonColor]; for the intended behavior to show.

from mathemekit.

17e0476 Should fix it. Let me know how that works.

from mathemekit.

Issue fixed! Thanks.

from mathemekit.

No, thank you!

from mathemekit.