Comments (6)
I made a PR to improve this :)
You have inherited a pretty old codebase... It would benefit from some upgrades but that's a daunting task :/
So many thanks for keeping this alive, because this project is very useful.
from linqtoxsdcore.
Seems like a sensible suggestion, and with this reply I note my approval for either yourself or anyone else to begin work on a PR or issue one in the future.
from linqtoxsdcore.
@mamift That PR had a stupid mistake where the backing field is typed as string
, should have been XName
of course.
#25 fixes that.
from linqtoxsdcore.
@mamift I found a bug in this PR today.
When your XSD contains inheritance, the child class need access to the parent XName fields (for its BuildElementDictionary
).
So right now the generated code may not compile.
I fixed this by making the XName fields internal instead of private and added EditorBrowsable.Never
so that they don't show up as static members for users.
PR coming soon (w/ the nullable refs).
from linqtoxsdcore.
@mamift Small bit of feedback here.
Using this in our real work, I noticed that EditorBrowsableState.Never
is not respected by VS 2019.
I was quite surprised and I learnt that VS doesn't apply this attribute in the same solution.
It kind of makes sense as if you develop a lib you probably want to see all members in IDE (and hide them from consumers of the lib).
That perspective is of course a bit broken when it comes to generated code, which is a bit of a lib in your own code...
So just so you know, this attribute is useless right now but there is a long standing Roslyn issue about it:
dotnet/roslyn#4434 (comment)
from linqtoxsdcore.
Well, someone pointed this isn't actually the issue here and the behavior was expected.
I opened dotnet/roslyn#51269 to see if that behaviour could be changed.
If not, you can remove the EditorBrowsable
from codegen as they're useless.
from linqtoxsdcore.
Related Issues (20)
- Streaming? HOT 2
- Codegen bugs HOT 1
- Duplicate enums are not generated HOT 6
- Modify the LinqToXsd program such that it will emit one xml namespace to one corresponding c# file. HOT 13
- Empty namespace is not mapped when generating config file HOT 1
- Null Reference Exception with ILinqToXsdTypeManager HOT 2
- The content model inheritance is broken for types derived by restriction.
- Composite content model code is not generated.
- Missing null check in a ToXTypedElement of XTypedServices.cs
- maxOccurs="unbounded", is not respected for elements in choice block
- Eager/deferred/lazy? HOT 1
- error CS1061: 'object' does not contain a definition for 'TypeDefinition' HOT 8
- Generated code doesn't compile if an element is named Content HOT 3
- LinqToXsd config -e file.xsd does not gather all sub-namespaces
- Integrate core xml.xsd into the LinqToXsdCore library
- No globa:: prefix for BuildWrapperDictionary
- Nice to have: Load and Parse overloads with LoadOptions
- Parsing error when nullable elements with empty value and "xsi:nil"=true attribute HOT 3
- Schema versioning?
- [regression in v3.4.3+] error CS0108: OneField of ParentType hides inherited member OneField of ChildType HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from linqtoxsdcore.