Comments (2)
This is caused by the following code unconditionally doing a read to get the original value.
Lines 484 to 491 in a228465
One solution would be checking that the write only affects a part of the word, and only doing the read if that is the case.
I'm unsure whether the extra unused read is actually a problem? I suppose it could potentially confuse some hardware that do things on register reads, and it's probably better to stick to what ACPICA does if we want to work on real hardware.
from lai.
I'm unsure whether the extra unused read is actually a problem? I suppose it could potentially confuse some hardware that do things on register reads, and it's probably better to stick to what ACPICA does if we want to work on real hardware.
Yeah it's pretty much impossible to say, it might trip up some hardware, might not. There are probably some registers cleared by read? Another thing I thought of is if this was some other address space (aka not SystemMemory or SystemIO) but say SMBus. There a spurious read could cause more problems probably. At the very least it's extra wasted cycles or stalls for no reason.
from lai.
Related Issues (20)
- Feature request: Rust bindings HOT 3
- Hanging on Intel Core i3-10th gen laptop (Lenovo) HOT 1
- Panic on DELL laptop (AMD Ryzen 5500U)
- Fix ACPI Reset compatibility check
- Implement bankfields in opregion.c
- Timer test fails spuriously
- Lai panics with: invalid variable type 2 in lai_write_filed on real hw HOT 1
- lai_write_field does not check buffer size
- Lai panic: Else() outside of If() HOT 9
- lai_populate fails with LAI_UNEXPECTED_RESULT
- timer.c: Misuse of laihost_map API
- Assertion failed: i < ht->bucket_capacity HOT 2
- HP Pavilion Slimline S5520BR hangs when executing \_PTS(5) HOT 4
- Concatenate(String, RefOf) is broken
- Increment/Decrement are implemented incorrectly
- Continue doesn't know how to find innermost While
- LAI fails to pass the ACPICA arithmetic test
- Invoking _GTS is a bad idea
- connect field HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lai.