Giter VIP home page Giter VIP logo

Comments (3)

Ana06 avatar Ana06 commented on June 12, 2024

You shouldn't have to do this manually. It is being restored in the hook:
git stash pop -q --index
https://github.com/fireeye/capa/blob/master/scripts/hooks/pre-push#L14

The only case in which the changes are not restored is if you manually abort while the hook is running. Could this have been the case? There is a warning printing the message used to stash the changes in case it is needed to restore it manually:

"Uncommited changes stashed with message '$MSG', if you abort before they are restored run \`git stash pop\`"

https://github.com/fireeye/capa/blob/master/scripts/hooks/pre-push#L9

If you didn't abort manually, could you provide more details about when this happens (for example the git version you have installed)?

from capa.

williballenthin avatar williballenthin commented on June 12, 2024

i think my expectations were probably just different from those of the hooks. i've modified my hooks to be very minimal. for now, lets call this PEBKAC!

from capa.

Ana06 avatar Ana06 commented on June 12, 2024

@williballenthin I was looking at pre-push when I first read the issue. I think you are right: There is a bug in post-commit which prevent the changes from being restored. Sorry for that. I'll send a PR to fix it.

from capa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.