Comments (4)
The error logs of periphery is written in your log. Isn't it enough?
Shell command '/usr/bin/env xcodebuild -project /Users/test/Some.xcodeproj -list -json' returned exit status '74'
This error is from here https://github.com/peripheryapp/periphery/blob/2173f0d5cb09bf5708776224b0b56f239dbff3f5/Sources/XcodeSupport/Xcodebuild.swift#L76
from danger-periphery.
@manicmaniac Not really as exit code 74 is really broad. Seems like we don't spit out the stdout here(
danger-periphery/lib/periphery/runner.rb
Line 16 in 4fd02a1
when the exception is raised so all the detailed logs is never printed out.
Also this is possibly a separate issue but sending down verbose: true
is not respected as I don't see the verbose periphery logs either
from danger-periphery.
Hmm... let me get this straight.
Shell command '/usr/bin/env xcodebuild -project /Users/test/Some.xcodeproj -list -json' returned exit status '74'
This message includes all output from stderr. I agree exit status '74' is so broad but that is the raw text from Periphery
.
The former part xcodebuild -project /Users/test/Some.xcodeproj -list -json
looks more important in this case.
when the exception is raised so all the detailed logs is never printed out.
As you say danger-periphery
suppresses stdout once an error occurs.
However, about this case, I don't think analyzing stdout helps your debug because Periphery
dies in early stage and I guess it writes nothing meaningful to stdout.
Also this is possibly a separate issue but sending down verbose: true is not respected as I don't see the verbose periphery logs either
Yes, passing verbose: true
option to periphery.scan
is passed through to Periphery
executable so danger-periphery
doesn't recognize it. In other words, there's no "verbose" option in danger-periphery
now.
Generally speaking, I agree that danger-periphery
might have to print stdout from Periphery
for more complex error. But ususally stdout log is much bigger than stderr log so simply adding stdout log to raised error doesn't sound nice.
If you have a good idea, I'm welcome to hear that or you can open a pull request.
from danger-periphery.
"Yes, passing verbose: true option to periphery.scan is passed through to Periphery executable so danger-periphery doesn't recognize it. In other words, there's no "verbose" option in danger-periphery now."
It would be nice to be able to override this. I'm trying to debug an issue right now where I see no output at all on my CI machines, while running danger locally detects one violation.
It's hard to tell if periphery is even running on the CI machines.
from danger-periphery.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from danger-periphery.