Comments (6)
Save config before doing anything else when closing. Removed unnecessary
creation of
pgfilter (possible slowing down the saving).
Should put this in another interim release so users who are experiencing this
can
verify it works for them.
Original comment by nightstalkerz
on 21 Aug 2009 at 11:15
Attachments:
from peerblock.
Original comment by [email protected]
on 22 Aug 2009 at 1:11
- Changed state: Started
from peerblock.
I don't see any "removed unnecessary creation of pgfilter" in the patch... Was
this
an older version patch-file or something? ...or did you mean the
unnecessarily-duplicated call to g_config.Save()?
Original comment by [email protected]
on 22 Aug 2009 at 1:51
from peerblock.
It's on line 19 where we assign g_filter again.
There's only 1 place where g_config.Save() is called and it is at the top. The
bottom
one is just removing it.
The main change for this patch was to call g_config.Save() before doing
anything else
in the Main_OnDestroy() method.
Original comment by nightstalkerz
on 22 Aug 2009 at 10:31
from peerblock.
Wow, yeah, I see it now. Must have been delirious last night or something, I
swear
the patch looked entirely different... =;)
Will sanity test the fix then get it checked-in and pushed off to the Beta Team
for
initial testing, will generate another Interim Release sometime after they have
a
chance to bang away at it for a bit.
Thanks for the patch!
Original comment by [email protected]
on 22 Aug 2009 at 3:54
from peerblock.
Marking as Fixed with the r102 commit. We can reopen the bug if it turns out
otherwise.
Original comment by [email protected]
on 24 Aug 2009 at 12:46
- Changed state: Fixed
from peerblock.
Related Issues (20)
- Range (Blocked Name) not being displayed
- v1.2 won't install in XP SP2 HOT 2
- Peerblock blocks me from trying to play online on Warcraft 3 (Blizzard Entertainment)
- Conflict with NETIO.SYS causing BSOD
- Allow downloading lists from adblockplus.org sources. HOT 2
- an uncaught exceception SQL.logic or database missing
- Lists Not Updating
- History Log?
- Advanced IP paste
- SQL Logic error or missing database HOT 2
- permanently allow
- Right click to 'permanently allow' an IP address doesn't work
- peerblock won't open - because of win32
- Can't get PB to work HOT 1
- Exception occured when loading the blocked lists. HOT 1
- please move this project to Github!
- Switch to GitHub? HOT 1
- List Manager GUI unable to click education HOT 2
- Move to another site like GitHub or SourceForge?
- Enhancement of the open port feature.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from peerblock.