Giter VIP home page Giter VIP logo

Comments (5)

nissoh avatar nissoh commented on May 29, 2024

scope.$apply();
change to
$scope.$$phase || scope.$apply();

although this would solve your issue. i think generally $scope.$apply() should be very specific

from angular-gridster.

coryasilva avatar coryasilva commented on May 29, 2024

After doing some reading, the $timeout (with a true parameter) creates a deferred and then calls $scope.$apply. While not being as semantic it is more "zen" as it does not rely on the undocumented $$phase value.

That said, I understand the $timeout is a little ugly and that $$phase should not be deprecated until Angular 2.0(ish) so I could go either way on this issue.

from angular-gridster.

danomatic avatar danomatic commented on May 29, 2024

I think the issue is that resize is sometimes called within an angular cycle and sometimes from a non-angular event. That can probably be fixed in the code that calls resize, rather than making resize do timeouts and other special code to handle the different usages.

from angular-gridster.

coryasilva avatar coryasilva commented on May 29, 2024

Sounds 10x better; I definitely will read through/understand the source better.

from angular-gridster.

danomatic avatar danomatic commented on May 29, 2024

Fix just pushed. Closing for now. Please report any regressions.

from angular-gridster.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.