Bug: Long texts length is not matching output area in Jupyter about halo HOT 7 OPEN

I checked it occurred because of wrong get_terminal_size(). In jupyter, width of Output widget is not related with terminal size. But in HaloNotebook._get_text(), it use get_terminal_columns() via backports.shutil_get_terminal_size.get_terminal_size().

backports.shutil_get_terminal_size.get_terminal_size() decide terminal width using columns = int(os.environ["COLUMNS"]). But jupyter widget is independent with terminal size and related with HMTL/CSS. So I'm searching to get current jupyter cell's width and how to convert to ascii terminal size like 80, 120, etc.

from halo.

@jungwinter Could you look into this?

from halo.

@jungwinter That is correct. I was trying to find a way around this but I think there is no official way. I was thinking of injecting some javascript code to get actual width and converting it to terminal size.

from halo.

@jungwinter I've made a release with Jupyter support for now. This issue is still not resolved and needs to be fixed (probably with a new approach).

from halo.

Is this issue still open? I would like to work on this issue. Can you please assign this to me?

from halo.

I think it's still happening. @manrajgrover Could you confirm ajjayymahato's request? (At least, #165 issue is also needed to check.)

from halo.

If this issue is open can you please assign it to me so that I can work on it?

from halo.