UX missing previous $location.path() for status 401 about manshar HOT 5 CLOSED

You are right @3emad!

So the scenario of implementing this, IMO, is tracking when we get 401, save $location.path() in cookies _redierect_to just before redirect to the login page.

After login (or whatever), check $cookies._redirect_to if existed then redirect to that path.

@RashaHussein?

from manshar.

@amrnt I noticed the script expects the backend to return a response having two properties that depends on which are redirecting to login and assigning previous path, referring to this script:

$q.reject({
              redirectTo: '/login',
              previous: $location.path()
            }) 

looking at this line, It seems we could just make sure the response object has the property of previous,maybe something like this:

'responseError': function(response) {
        if (response.status === 401) {
         if( typeof response.previous !== 'string')
            response.previous = $location.path();
          $location.path('/login');
          return $q.reject(response);
        }
        else {
          return $q.reject(response);
        }

on another thought if that works, even better:

'responseError': function(response) {
        if (response.status === 401) {
         if( typeof response.previous !== 'string')
            response.previous = $location.path();
          if( typeof response.redirectTo !== 'string')
            response.redirectTo = '/login';
          return $q.reject(response);
        }
        else {
          return $q.reject(response);
        }

Thoughts?

from manshar.

Great catch Emad.

I don't think this should rely on backend logic and the client should know where to go by itself.

The fix should be simple, in the resonseError part of the interceptor, we just need to set 'prev' search parameter on the location we're redirecting the user to ('/login'). LoginCtrl already knows what to do when a successful login happen when we have a prev parameter. So responseError becomes:

  'responseError': function(response) {
    if (response.status === 401) {
      var previous = $location.path();
      $location.path('/login').search('prev', previous);
      return $q.reject(response);
    }
    else {
      return $q.reject(response);
    }
  }

I don't think the method 3emad proposed would be caught by $routeChangeError listener as this wasn't a route change (in the Angular Route sense).

Wanna create a pull request?

from manshar.

@mkhatib your correct, haven't used http interceptors before.

from manshar.

Wohoo! Thanks @3emad

from manshar.