Comments (8)
shouldn't it just refresh the page at least ?
from manshar.
Yeah I think it shouldn't redirect and just remove the deleted article from the list. (It shouldn't even refresh).
from manshar.
Let me know if you'd like to take this on and try to send a pull request to fix it.
from manshar.
sure, actually am working on it now.
from manshar.
Disclaimer: Am not a js/angularjs professional 💃
$scope.deleteArticle = function(article) {
$scope.inProgress = 'delete';
if ($window.confirm('متأكد من حذف المقال؟')) {
Article.delete({ 'articleId': article.id }, {}, deleteSuccess, deleteError);
//my humble - awesome attractive - addition
var index = $scope.drafts.indexOf(article);
$scope.drafts.splice(index, 1);
//
} else {
$scope.inProgress = null;
}
};
it works great, only for the first deletion 😄 , after that the delete button refuses to respond! I've tried to re query the drafts on the deleteSuccess
method but with no success.
a refresh would solve that, but it's a very bad UX practice.
that's my first time to touch the angularjs thingy so please forgive all of my sins 🙏
from manshar.
This looks great. My guess the problem you are having is because of not resetting $scope.inProgress to null inside deleteSuccess and deleteError.
from manshar.
Hallelujah, here you are 🍭 you nailed it.
from manshar.
Do you want to try and send a pull request?
from manshar.
Related Issues (20)
- Allow Community Moderators to make limited changes directly to the articles, for example: Removing extra whitespace, Making styling changes HOT 1
- Check if editor picks only one article at a time. HOT 1
- Comments flows behind Author card
- Expose an API to allow admins to update the role of a user
- Send Email notification to users when promoted to staff
- Add an item under admin dashboard for managing user roles
- Build admin UI for filtering users by names and promoting them to staff
- List all staff members and allow demoting them back to authors
- Expose an API to list users by role
- Add codeclimate
- Add rubocop to catch syntax errors.
- Broken API/ trouble accessing my Manshar account HOT 3
- Profile name is not updated in published articles HOT 5
- Manshar Story URL is broken
- updated articles' titles don't show up once shared on facebook HOT 2
- Add news from the development team category HOT 3
- Cann't reset my password HOT 2
- Update: the article was published later HOT 1
- For anyone looking for the data HOT 2
- Who to contact for security issues HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from manshar.