Redirection after deleting a draft. about manshar HOT 8 CLOSED

shouldn't it just refresh the page at least ?

from manshar.

Yeah I think it shouldn't redirect and just remove the deleted article from the list. (It shouldn't even refresh).

from manshar.

Let me know if you'd like to take this on and try to send a pull request to fix it.

from manshar.

sure, actually am working on it now.

from manshar.

Disclaimer: Am not a js/angularjs professional 💃

$scope.deleteArticle = function(article) {
      $scope.inProgress = 'delete';
      if ($window.confirm('متأكد من حذف المقال؟')) {
        Article.delete({ 'articleId': article.id }, {}, deleteSuccess, deleteError);
        //my humble - awesome attractive - addition
        var index = $scope.drafts.indexOf(article);
        $scope.drafts.splice(index, 1);
        //
      } else {
        $scope.inProgress = null;
      }
    };

it works great, only for the first deletion 😄 , after that the delete button refuses to respond! I've tried to re query the drafts on the deleteSuccess method but with no success.
a refresh would solve that, but it's a very bad UX practice.
that's my first time to touch the angularjs thingy so please forgive all of my sins 🙏

from manshar.

This looks great. My guess the problem you are having is because of not resetting $scope.inProgress to null inside deleteSuccess and deleteError.

from manshar.

Hallelujah, here you are 🍭 you nailed it.

from manshar.

Do you want to try and send a pull request?

from manshar.