Some small issues about manshar HOT 6 CLOSED

Nice hunts 👍

from manshar.

Thanks @qjouda

Will investigate firefox bugs, we have few bugs already open for Firefox.

Autosaving a non-dirty article will be fixed in the next push.

All other points are valid and we'll be working on fixing them, thanks for pointing them out 🙇

OPTIONS requests are made automatically by the browser when doing cross domain requests. Luckily they're heavily cached by the browsers so they will not be called again after the first time. The browser just needs to make sure this domain can make cross domain requests to the other. It might be worth investigating using a single domain with a path for apis instead (I think @mshamma mentioned something like that). But for now there are more urgent matters for performance that we're looking into.

Great points!

from manshar.

Auto-saving should only run on dirty check now.

from manshar.

Cool. For the OPTIONS, it was my bad, I had the cache disabled so OPTIONS was firing every time!

from manshar.

Yup. Fell in the same mistake and had to investigate myself 😊

On Tue, Feb 24, 2015, 3:53 AM Qusai [email protected] wrote:

Cool. For the OPTIONS, it was my bad, I had the cache disabled so OPTIONS
was firing every time!

—
Reply to this email directly or view it on GitHub
#172 (comment).

from manshar.

New design should have touched on some of the issues in this. Will file separate bug for the not-found page.

from manshar.