Giter VIP home page Giter VIP logo

Comments (6)

mantoni avatar mantoni commented on May 13, 2024

Hm, yeah, I thought about that.

I use Mochify in a lot of small projects as a devDependency so that they are serving all the things you need (except for PhantomJS). So I like the idea generally.

I'm a bit afraid of adding a dependency that is so large to something I install so frequently. It is already available in environments like Travis and also easy enough to install locally and you real only need one version of it. There is no need to nail down the PhantomJS version, I think. It feels a bit like adding all the gcc tools to your dependencies because you want to compile some c haha.

Does that make any sense?

from mochify.js.

sindresorhus avatar sindresorhus commented on May 13, 2024

I'm a bit afraid of adding a dependency that is so large to something I install so frequently. It is already available in environments like Travis and also easy enough to install locally and you real only need one version of it.

It will only install a local copy if there's no global one or the global one is too old.

I would want to make it as painless as possible for users to get started. Just being able to npm install mochify without having to do anything else would be nice for users. But I don't really care. I don't use this yet, just a suggestion from a lot of experience with creating tools ;)

from mochify.js.

mantoni avatar mantoni commented on May 13, 2024

Oh nice, I didn't know! I'm already convinced :-)

from mochify.js.

mantoni avatar mantoni commented on May 13, 2024

Instead of depending on the phantomjs module, I added a message stating this as an option.

from mochify.js.

lukasoppermann avatar lukasoppermann commented on May 13, 2024

Can you please add this to the dependencies? It is really annoying, I tend to forget to install it and it is not really nice, to have deps in your package.json that are actually deps of a package and not your main project.

from mochify.js.

mantoni avatar mantoni commented on May 13, 2024

The last time I checked, the npm dependency did not recognize my global install and would download the whole phantomjs thing on each fresh install. This is why I've decided to just print a message explaining what to do.

from mochify.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.