Giter VIP home page Giter VIP logo

Comments (1)

manzt avatar manzt commented on September 6, 2024

hmm doesn't seem like Response is provided as a global in Node.js... would likely need to allow the current interface as well with Uint8Array.

Actually this works in Node v18:

import { open } from 'node:fs/promises';

let file = await open('./package.json');
let response = new Response(file.readableWebStream());
await response.json();
file.read() // promise! oh no, file still open :x 

EDIT: Errr actually, a tiny detail in the node docs:

While the ReadableStream will read the file to completion, it will not close the FileHandle automatically. User code must still call the fileHandle.close() method.

Since we don't want to manage open file handles, it seems like the correct way to do this is to first create a Readable which auto-closes the file (when read) and get a ReadableStream from that. This way the caller is in control over then the file is closed (and doesn't need a reference to the original FileHandle).

import { open } from 'node:fs/promises';
import { Readable } from 'node:stream';

let file = await open('./package.json');
let readable = file.createReadStream({ autoClose: true });
let response = new Response(Readable.toWeb(readable));
await response.json()
file.read() // Error! file closed

from zarrita.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.