Comments (12)
@Mordag thank you for the ping, this is indeed on our radar as the stable hit at the end of September. Added this to 7.0 milestone to reflect this.
from mapbox-gl-native-android.
Going to the process myself atm and google has a done a great job with jetifier :) just small side note that you need to bump gradle tools version to at least 3.2.0
from mapbox-gl-native-android.
Any chance you are going to move forward with this soon? I'm deciding between MapBox and Google Maps, and one deciding factor is that Jetifier increases build time, and Google Maps recently moved over to AndroidX.
from mapbox-gl-native-android.
This feature is available in Android Studio Canary 14 for applications targeting Android P.
Not sure if this only applies to the Android Studio plugin feature, but it seems that in order to be able to include AndroidX libraries we'll need to target Android P (API level 28) instead of the current API level 27. Do we have ticket tracking targeting P?
from mapbox-gl-native-android.
@tobrun Is there any chance that AndroidX migration will be part of the next SEMVER (7.0.0)? AndroidX hit 1.0 just a few weeks ago.
from mapbox-gl-native-android.
@Mordag just asking as an interest, do you have any issues with using AndroidX with a current mapbox versions? If you use android.enableJetifier=true
it should migrate our support dependencies to androidx equivalent at build time.
from mapbox-gl-native-android.
@tobrun I haven't tried to do this yet to be honest. It's on our roadmap to migrate to AndroidX soonish. I will give a try in the next days to see if it would cause any problems.
from mapbox-gl-native-android.
Capturing from mapbox/mapbox-gl-native#13320 that we aren't moving forward at this time as users can leverage jetifier to compile this project with androidx.
from mapbox-gl-native-android.
can't give a concrete eta atm, we are hoping to migrate asap but some clients are pushing back since they didn't go through the migration yet. Ideally we are able to hit this in the upcoming months. That said, once a library has been jetified it shouldn't impact build time. Haven't done any benchmark from my end but to what extend does your build time increase?
from mapbox-gl-native-android.
It's mostly an issue in clean environments like CI. I don't have the numbers in front of me; they're not huge but androidx has been stable for a while now, so it seems silly to us to have any performance hit because of it.
If there are clients that don't want to / can't update, is it helpful to point them to http://ncorti.com/blog/jetifier-reverse
I also filed an issue in Google related to this - https://issuetracker.google.com/issues/137035109
from mapbox-gl-native-android.
Thanks @eygraber for sharing those links, I'll check them out. An additional consideration is that this change will be a SEMVER major change, which we try to minimize to avoid impacting the developer experience. We'll definitely keep this ticket in mind when we plan the next one.
from mapbox-gl-native-android.
this landed in v9.0.0
from mapbox-gl-native-android.
Related Issues (20)
- Change MAPBOX_ACCESS_TOKEN on runtime HOT 1
- jcenter sunset - release code to maven HOT 3
- Incorrect TalkBack accessibility feedback when gesture interaction is disabled
- Error when trying to display map
- MapView sometime doesn't load the map `(failed to connect to api.mapbox.com/64:ff9b::6c9d:ba (port 443))` HOT 1
- Location tracking issues Android 12 HOT 1
- Crash when using android.uid.system
- Flutter useHybridComposition cause crash HOT 4
- android 12, APP keep crashing
- Intergrate Android Auto
- Source code for mapbox-android-sdk-gl-core
- Mapbox sometimes crash, android 9
- The animation of the location component has lags when the RenderMode.COMPASS and mapbox_elevation=0dp are set
- Mapbox gets app rejected HOT 1
- Center to user location
- PropertyFactory.lineColor not working HOT 1
- E2E Tests implementation
- SoLoader load 'mapbox-gl' with FileLockInterruptionException
- Unable to generate DOCS using javadoc in android studio HOT 1
- LocationComponent crashing on Android 13 and 12 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mapbox-gl-native-android.