Giter VIP home page Giter VIP logo

Comments (12)

tobrun avatar tobrun commented on May 16, 2024 1

@Mordag thank you for the ping, this is indeed on our radar as the stable hit at the end of September. Added this to 7.0 milestone to reflect this.

from mapbox-gl-native-android.

tobrun avatar tobrun commented on May 16, 2024 1

Going to the process myself atm and google has a done a great job with jetifier :) just small side note that you need to bump gradle tools version to at least 3.2.0

from mapbox-gl-native-android.

eygraber avatar eygraber commented on May 16, 2024 1

Any chance you are going to move forward with this soon? I'm deciding between MapBox and Google Maps, and one deciding factor is that Jetifier increases build time, and Google Maps recently moved over to AndroidX.

from mapbox-gl-native-android.

zugaldia avatar zugaldia commented on May 16, 2024

This feature is available in Android Studio Canary 14 for applications targeting Android P.

Not sure if this only applies to the Android Studio plugin feature, but it seems that in order to be able to include AndroidX libraries we'll need to target Android P (API level 28) instead of the current API level 27. Do we have ticket tracking targeting P?

from mapbox-gl-native-android.

AlexanderEggers avatar AlexanderEggers commented on May 16, 2024

@tobrun Is there any chance that AndroidX migration will be part of the next SEMVER (7.0.0)? AndroidX hit 1.0 just a few weeks ago.

from mapbox-gl-native-android.

tobrun avatar tobrun commented on May 16, 2024

@Mordag just asking as an interest, do you have any issues with using AndroidX with a current mapbox versions? If you use android.enableJetifier=true it should migrate our support dependencies to androidx equivalent at build time.

from mapbox-gl-native-android.

AlexanderEggers avatar AlexanderEggers commented on May 16, 2024

@tobrun I haven't tried to do this yet to be honest. It's on our roadmap to migrate to AndroidX soonish. I will give a try in the next days to see if it would cause any problems.

from mapbox-gl-native-android.

tobrun avatar tobrun commented on May 16, 2024

Capturing from mapbox/mapbox-gl-native#13320 that we aren't moving forward at this time as users can leverage jetifier to compile this project with androidx.

from mapbox-gl-native-android.

tobrun avatar tobrun commented on May 16, 2024

can't give a concrete eta atm, we are hoping to migrate asap but some clients are pushing back since they didn't go through the migration yet. Ideally we are able to hit this in the upcoming months. That said, once a library has been jetified it shouldn't impact build time. Haven't done any benchmark from my end but to what extend does your build time increase?

from mapbox-gl-native-android.

eygraber avatar eygraber commented on May 16, 2024

It's mostly an issue in clean environments like CI. I don't have the numbers in front of me; they're not huge but androidx has been stable for a while now, so it seems silly to us to have any performance hit because of it.

If there are clients that don't want to / can't update, is it helpful to point them to http://ncorti.com/blog/jetifier-reverse

I also filed an issue in Google related to this - https://issuetracker.google.com/issues/137035109

from mapbox-gl-native-android.

zugaldia avatar zugaldia commented on May 16, 2024

Thanks @eygraber for sharing those links, I'll check them out. An additional consideration is that this change will be a SEMVER major change, which we try to minimize to avoid impacting the developer experience. We'll definitely keep this ticket in mind when we plan the next one.

from mapbox-gl-native-android.

tobrun avatar tobrun commented on May 16, 2024

this landed in v9.0.0

from mapbox-gl-native-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.