Giter VIP home page Giter VIP logo

Comments (6)

mapsam avatar mapsam commented on August 14, 2024 1

@mapbox/[email protected] has been published from 13d4ac7.

I need to push package.json version changes to GitHub in order to publish to the @mapbox/ namespace, so technically the version is published from 996b31b.

I'll use https://github.com/mapbox/node-pre-gyp/tree/mapsam/v1.1.0-pre and keep it in sync with master as you need more dev releases and until the GitHub Actions work is set up.

@cclauss let me know if you'd prefer a separate ticket to request/discuss releases, just to keep this issue focused on the GitHub Action work!

from node-pre-gyp.

acalcutt avatar acalcutt commented on August 14, 2024

In maplibre-native workflow we settled on this workflow that checks if the version in package.json is published.
https://github.com/maplibre/maplibre-native/blob/main/.github/workflows/node-release.yml#L9-L34

If it is not published it runs the build
https://github.com/maplibre/maplibre-native/blob/main/.github/workflows/node-release.yml#L38

maybe something like that would work here. Seems like it would be easier because this project doesn't really need to build anything, just run the publish steps.
https://github.com/maplibre/maplibre-native/blob/main/.github/workflows/node-release.yml#L304-L310

from node-pre-gyp.

cclauss avatar cclauss commented on August 14, 2024

Cool! Pull requests will be reviewed. Let's see how that approach works.

from node-pre-gyp.

mapsam avatar mapsam commented on August 14, 2024

I'm in favor of GitHub release for this as well. This may be blocked by using the @mapbox/node-pre-gyp namespace for a bit, since the Mapbox NPM scope is pretty locked down and I'm not sure we'll be able to grant tokens for public repositories like this. Ultimately this is a good argument to move back to the unscoped node-pre-gyp NPM module which does not have the same security restrictions.

Not ideal, but in the short-term I can cut one-off prereleases for @mapbox/node-pre-gyp as needed @cclauss

from node-pre-gyp.

cclauss avatar cclauss commented on August 14, 2024

I understand the complexities. I think we need a pre-release and then a release BEFORE we merge other changes (all the Dependabot changes, etc.). Please proceed with that pre-release when you feel comfortable doing so.

from node-pre-gyp.

mapsam avatar mapsam commented on August 14, 2024

Sounds good! Can you give me a commit to prerelease from? Just want to make sure I release what you're expecting. Latest master is 13d4ac7

I'll plan on 1.1.0-dev.1 since Node.js 22 has been added, but if you see this as a breaking change happy to move into v2 v1.0.11...master

from node-pre-gyp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.