Entries in tiles cache released too early about tilelive-mapnik HOT 9 CLOSED

Forgot to mention: my tests were conducted with tilelive-mapnik 0.3.2 but I see that also master is affected

from tilelive-mapnik.

See also #14

from tilelive-mapnik.

happy to review a pull request that keeps existing functionality (used by TileMill) but extends the code to have options for more flexible uses.

from tilelive-mapnik.

note: if/as you are working on this - there are a few other locking cache tickets you may or may not be interested in.

from tilelive-mapnik.

There was a pull request from @tokumine which was about having the policy specified by a parameter passed to LockingCache, but I'm afraid the same parameter wasn't accessible from the outside.

from tilelive-mapnik.

I think I'm done with this task, anyway if you add a "LockingCache" label for the issues it'll be easier to look at them next time I'm around :)

from tilelive-mapnik.

The LockingCache removes the item it triggers immediately (and doesn't wait until the timer expires/deletes the timer) because when we wrote it, tilelive-mapnik was mainly used for generating MBTiles files. Since every tile is requested exactly once there is no need to keep them in the cache until they expire. This expectation doesn't hold of course in a setup where you request tiles at random.

from tilelive-mapnik.

So will @rcoup commit be merged or should it be enhanced to expose a parameter (as per #14) ?

from tilelive-mapnik.

see #57 which is viable and will supersede this.

from tilelive-mapnik.