Giter VIP home page Giter VIP logo

Comments (4)

olt avatar olt commented on June 5, 2024

In general it depends on a) the feature and b) the implementation.

For a)
It is great to have new cache backend options, especially for users that use MapProxy as one tool among others in a larger project. So GeoPackage support is welcomed as a new cache backend. The only issue I see is that it is still a changing spec. Are you willing to update the implementation till the OGC releases a final version?

For b)
New features need to follow or improve the existing style of MapProxy (architecture, coding, testing and documentation). I encourage you to make a pull request if you are willing to polish the implementation. Dumping a "works for me" implementation is fine, but it won't be merged until someone (maybe even me) finds the time to "make it right".

Let me know if you have something to look at and I can give you feedback on whats missing.

from mapproxy.

stevendlander avatar stevendlander commented on June 5, 2024

A) The OGC review committee appears to only be changing their metadata tables from now until final approval, according to my sources. The tile tables have remained unchanged and most likely will continue that trend until final release. Since MapProxy is currently the only software existing that supports serving geopackages over WMS/TMS standards, I think it is in our best interest to keep the software current. Short answer: yes :)

B) I believe I have most of this already done since I leaned heavily on the mbtiles implementation, as they are quite similar. I have not yet designed tests or even looked at how you approach test cases but I see no reason why I couldn't get everything up to acceptable standards including documentation.

I will send a link to this discussion to my superiors and make the case. Until I get approval to submit the pull request I will double check that my code conforms to comment and code styling, then work on the test cases and documentation.

from mapproxy.

olt avatar olt commented on June 5, 2024

Cool!

See here for example tests: https://github.com/mapproxy/mapproxy/blob/master/mapproxy/test/unit/test_cache_tile.py#L250..L306
The base test class TileCacheTestBase makes sure that the cache adheres to the MapProxy caching API (which is not formally defined, but the tests make sure they all work the same). You should add more GeoPackage specific tests with new test methods.

Also make sure that any new dependencies are optional, if there are any (Spatialite shouldn't be required for a raster GeoPackage).

from mapproxy.

posikifi avatar posikifi commented on June 5, 2024

Hi,

Is there any plans include Geopackages as one of the possibilities for caches?

P

from mapproxy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.