EditingWidget redesign about mapsui HOT 2 OPEN

I agree with most points.

I think the GetAlternateMode() would solve the Editing Problems on Mobile/Touch Platforms.

There could be a Property that tells if the GetAlternateMode is supported in the platform and if not an Alternate Mode Button is displayed in the Editing Widget.

Or there could be a Property For displaying the AlternateModeButton on Mobile Platforms this is initially true. If it is set to false the GetAlternateMode Function needs to be implemented when it isn't implemented it throws an exception.

from mapsui.

@inforithmics I have been in submarine-mode in the previous weeks, focusing on manipulation (touch and mouse) and tackling anything that got in my way. The situation has completely change to when I wrote this post initially.

Some remarks:

• The EditingWidget should not have priority but for the work on manipulation it served as a very useful testcase. It was problematic because the old manipulation implementation was problematic. I to make the EditingWidget usable on all platforms, also with touch.
• GetShiftState is now a method that needs to be implemented on all platforms (because it is called from the shared code, and it would not compile without). The implementation was not fixed yet. I think we should fix it because for mouse users this is really helpful. This means we need to start tracking key state on those platforms.
• I mention not supporting double click. Because it was entangle with platform specifics and did not function the same way on all platforms. In main there is now a TapGestureTracker which is used on all platforms. It also detects double click. And it may also implement long press. Its logic is quite isolated.
• In general I am very happy with how the manipulations turned out. We have three trackers: TapGestureTracker, FlingTracker (not really looked at that, could perhaps be improved, but it works) and the ManipulationTracker. That last one isolates a lot of previously very complicated things. Now you just call it with an array of all the contact positions, and it then calls Navigator.Manipulate with a Manipulation state parameter: _manipulationTracker.Manipulate(positions, Map.Navigator.Manipulate);, we do not need to distinguish between a drag and pinch mode.
• Now that double click is possible it becomes possible to use editing on mobile which makes an alternative less necessary.
• I think we should not add GetAlternateMode to the MapControl or eventArgs. If anything it should be a state in the EditingWidget itself. Actually we already have buttons used in the EditingWidget that change state, they are used in the top Editing sample that you updated for skia.
• If we implement GetShiftState it might also become logical to go all the way with the modifier keys.

from mapsui.