Comments (6)
onleftclick
should probably just beonclick
but only trigger on left clicks, addingonrightclick
andonmiddleclick
sounds nice, although I am not sure about the names, after this,trigger_button
could be removedIn some very specific cases developers may want to detect the
Forward
,Back
andOther(u16)
variants of thetrigger_button
, which might be a reason to keeponclick
generic withtrigger_button
. Or just createonforwardclick
andonbackclick
but I don't know whatOther(u16)
is supposed to represent.you can still use
onpointerup
for that
True. In that case feel free to make onclick
only fire on left clicks. Although with pointer events you will have to pattern match to check if it's even a mouse. Though I suppose that doesn't hurt for those very specific cases with "forward" and "back" clicks.
from freya.
I think this should also be done for onglobalclick
, onglobalmousedown
and onmousedown
. It might introduce some duplication internally so maybe it could be done with a macro
from freya.
onleftclick
should probably just be onclick
but only trigger on left clicks, adding onrightclick
and onmiddleclick
sounds nice, although I am not sure about the names, after this, trigger_button
could be removed
from freya.
onleftclick
should probably just beonclick
but only trigger on left clicks, addingonrightclick
andonmiddleclick
sounds nice, although I am not sure about the names, after this,trigger_button
could be removed
In some very specific cases developers may want to detect the Forward
, Back
and Other(u16)
variants of the trigger_button
, which might be a reason to keep onclick
generic with trigger_button
. Or just create onforwardclick
and onbackclick
but I don't know what Other(u16)
is supposed to represent.
from freya.
onleftclick
should probably just beonclick
but only trigger on left clicks, addingonrightclick
andonmiddleclick
sounds nice, although I am not sure about the names, after this,trigger_button
could be removedIn some very specific cases developers may want to detect the
Forward
,Back
andOther(u16)
variants of thetrigger_button
, which might be a reason to keeponclick
generic withtrigger_button
. Or just createonforwardclick
andonbackclick
but I don't know whatOther(u16)
is supposed to represent.
you can still use onpointerup
for that
from freya.
Awesome, will do this change soon
from freya.
Related Issues (20)
- idea: Report/log wrongly-formatted attribute values
- enhancement: IME Support
- enhancement: Support special characters in text editing HOT 1
- When using tokio to do asynchronous operations, the window will freeze HOT 2
- bug: Inconsistent text render
- enhancement: Layers levels and mouse pass through problem HOT 9
- tracking: Dioxus 0.5 support
- Compiling failed! HOT 3
- Open Discussions for question about how to use Freya HOT 1
- enhancement: Clipboard support for Text editing
- enhancement: Undo & Redo support for Text editing
- idea: Turn the Drag & Drop example into a "Todo Demo"
- task: Fork Dioxus `native-core` crates HOT 4
- enhancement: Enable the Performance Plugin on debug builds and that can be toggled via a shortcut
- Unable to input Chinese
- request: Support images encoded in base64 inside SVG elements HOT 5
- enhancement : allow changing scrollbar thumbs and background color HOT 2
- refactor: Use enums for events names
- idea: Built-in caching mechanism for `Image` component
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from freya.