Giter VIP home page Giter VIP logo

Comments (6)

tigerros avatar tigerros commented on July 18, 2024 1

onleftclick should probably just be onclick but only trigger on left clicks, adding onrightclick and onmiddleclick sounds nice, although I am not sure about the names, after this, trigger_button could be removed

In some very specific cases developers may want to detect the Forward, Back and Other(u16) variants of the trigger_button, which might be a reason to keep onclick generic with trigger_button. Or just create onforwardclick and onbackclick but I don't know what Other(u16) is supposed to represent.

you can still use onpointerup for that

True. In that case feel free to make onclick only fire on left clicks. Although with pointer events you will have to pattern match to check if it's even a mouse. Though I suppose that doesn't hurt for those very specific cases with "forward" and "back" clicks.

from freya.

tigerros avatar tigerros commented on July 18, 2024

I think this should also be done for onglobalclick, onglobalmousedown and onmousedown. It might introduce some duplication internally so maybe it could be done with a macro

from freya.

marc2332 avatar marc2332 commented on July 18, 2024

onleftclick should probably just be onclick but only trigger on left clicks, adding onrightclick and onmiddleclick sounds nice, although I am not sure about the names, after this, trigger_button could be removed

from freya.

tigerros avatar tigerros commented on July 18, 2024

onleftclick should probably just be onclick but only trigger on left clicks, adding onrightclick and onmiddleclick sounds nice, although I am not sure about the names, after this, trigger_button could be removed

In some very specific cases developers may want to detect the Forward, Back and Other(u16) variants of the trigger_button, which might be a reason to keep onclick generic with trigger_button. Or just create onforwardclick and onbackclick but I don't know what Other(u16) is supposed to represent.

from freya.

marc2332 avatar marc2332 commented on July 18, 2024

onleftclick should probably just be onclick but only trigger on left clicks, adding onrightclick and onmiddleclick sounds nice, although I am not sure about the names, after this, trigger_button could be removed

In some very specific cases developers may want to detect the Forward, Back and Other(u16) variants of the trigger_button, which might be a reason to keep onclick generic with trigger_button. Or just create onforwardclick and onbackclick but I don't know what Other(u16) is supposed to represent.

you can still use onpointerup for that

from freya.

marc2332 avatar marc2332 commented on July 18, 2024

Awesome, will do this change soon

from freya.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.