bug: tab key is not listened with `onkeydown` and `onkeyup` about freya HOT 13 CLOSED

I've just tested it by adding these two lines in password example:

Works great! You probably want to start handling the Tab key event in places like use_editable too, so it insert a \t for Input & Textarea.

from freya.

Ah yeah, I was just too lazy to make the onkeydown handler hahaha.

That was a really fast fix! Thank you for the awesome work!

from freya.

Ah so it's not that it's not listened. It's used to detect navigation within the app

This prevented tab being treated as a real key input 😢

from freya.

Ah so it's not that it's not listened. It's used to detect navigation within the app

freya/crates/renderer/src/event_loop.rs

Lines 147 to 148 in 1b1eb3e

	if state == ElementState::Pressed
	&& physical_key == PhysicalKey::Code(KeyCode::Tab)

This prevented tab being treated as a real key input 😢

Yeah... I am aware of this but I haven't found a decent way yet to detect when to do one thing or another

I have thought about doing it with the Dioxus event propagation system but haven't tried yet

from freya.

Let me try

from freya.

Just opened #587 @ZeroX-DG

I made the keyboard navigation only work if the highest onkeydown doesn't stop the propagation of the event

It's not perfect but I think it's better

from freya.

Actually the PR is not entirely correct

from freya.

Yeah the PR is more like allowing tab key event to go through & perform navigation at the same time. (I'm just guessing, I'm not really familiar with freya codebase haha)

I think it's closer to the behaviour on the web that way since the JS way is to allow tab key & navigation to happen at the same time & you should call event.preventDefault() if you don't want navigation to happen.

from freya.

I have come up with a prevent_navigation method for the use_focus hook which should indeed prevent any navigation no matter where you call it from

from freya.

I have yet to actually test it but I think it should work

from freya.

You can then support indenting lines in valin editor! 😄

from freya.

I've just tested it by adding these two lines in password example:

Works great! You probably want to start handling the Tab key event in places like use_editable too, so it insert a \t for Input & Textarea.

Heads up: prevent_navigation is meant to be used inside of onkeydown events 😄.

I will add some docs and tests asap!

from freya.

You can then support indenting lines in valin editor! 😄

yeees! 🤣

from freya.