Giter VIP home page Giter VIP logo

Comments (5)

marcellourbani avatar marcellourbani commented on June 10, 2024

I think I saw it when I firstly coded this in the editor plugin but got lost in the rewrite.
Will have to look into it.
Classes work ok AFAIK, perhaps they fail when trying to activate a single include.
Will look into it

from abap-adt-api.

cohomology avatar cohomology commented on June 10, 2024

In our case we tried to activate a single whole class, not an include. We used setObjectSource on the main class and the public include beforehand.

Everything worked, iff we used "$TMP" package and "Z" namespace. As we switched from "$TMP" to a real package with transport request, it didn't work anymore.

I think ADT checks the result of the first call and omits the second call on demand. Exactly the place where you set "success: false" should trigger the second call.

from abap-adt-api.

marcellourbani avatar marcellourbani commented on June 10, 2024

Weird, as I don't have that problem in the editor plugin, which I'm using regularly.
Anyway it should be in the API, no question about that.
From what I see in the Eclipse responses, the response is what I expect already, so it should only a matter of exposing the parameter

I just pushed a change that should allow you to pass this from the caller, only validate it didn't break existing tests but didn't test the new call, partly because I suspect getting a proper test case would be a bit of a pain. (BTW, if you can provide a reliable one I will include in my test suite)

Could you please try if this works as expected? If so I'll bump the npm version and release it

from abap-adt-api.

cohomology avatar cohomology commented on June 10, 2024

Perhaps it doesn't work for me, because I have much more recent versions of Netweaver than you :-).

Just release it. It looks good for me. I will test it tomorrow. It is more easy to test if I can just take the released version.

from abap-adt-api.

marcellourbani avatar marcellourbani commented on June 10, 2024

from abap-adt-api.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.