Hi! I'm referring to the pull request <a class="issue-link js-issue-

This needs urgent attention. <a class="user-mention notranslate" data-hovercard-type="

Related conversation also at <a class="issue-link js-issue-link" data-error-text="Fail

Related conversation in a library relying on python-keycloak: <a class="issue-link js-

Thanks for bringing this up <a class="user-mention notranslate" data-hovercard-type="u

"exp" claim not checked because of check_claims parameter (jwcrypto) about python-keycloak HOT 5 CLOSED

cm253 commented on August 13, 2024 6

"exp" claim not checked because of check_claims parameter (jwcrypto)

from python-keycloak.

Comments (5)

sauerburger commented on August 13, 2024

This needs urgent attention. @marcospereirampj

from python-keycloak.

aboubacs commented on August 13, 2024

The change was for sure made too fast, there is no way to control the options anymore:

https://github.com/marcospereirampj/python-keycloak/pull/531/files#diff-0bbc8509272e0bb1f2f6be00fcb4f0ae29ff7522c88dcc085a305a0224659aa6R542-R547

=> What about all the other options ? Like verify_signature, etc

from python-keycloak.

Wim-De-Clercq commented on August 13, 2024

Related conversation also at #503 (comment)

from python-keycloak.

waza-ari commented on August 13, 2024

Related conversation in a library relying on python-keycloak: waza-ari/fastapi-keycloak-middleware#30

from python-keycloak.

ryshoooo commented on August 13, 2024

Thanks for bringing this up @cm253

I really feel reluctant to make a mapping between the old jose options to the jwcrypto options. Honestly, I prefer to make a breaking change here, change the signature completely, and just pass options for jwcrypto directly such that users can modify this to their own extent.

By merging #531 we have unfortunately made a breaking change already as the behavior is not the same anymore, so we might as well make it official and change the signature of the function.

from python-keycloak.

Recommend Projects