Using the set method on IE8 sometimes results in a crash (forced browser shutdown) about store.js HOT 7 CLOSED

Thanks for the report Ripster. Please let me know if you get the chance to create a repro or a patch.

from store.js.

I haven't reproduced this, but am thinking of using store.js in a fairly high-traffic app.

Looking at it, a storage crashbug in IE8 would be caused by store.js using IE8's new globalStorage implementation, so my guess is that #userData would still work in IE8 if it were written to pick that up instead.

I don't want to get mired in browser detection, so I'm just going to swap the if tests so that IE always uses #userData. I doubt this is something you want to include, but thoguht I'd mention it.

from store.js.

jdunck,

what makes you believe that the IE8 crash would be a result of using the globalStorage implementation?

Cheers,
Marcus

from store.js.

Well, I haven't reproduced, but looking at the implementation as it was, it uses globalStorage if it's available.

IE8 ships a globalStorage, and (presuming the crash really happens in IE8), that led me to believe that the globalStorage in IE8 caused the crash.

Do we agree that no web app should be able to crash the browser by using store.js? :-)

I'm just trying to avoid a reported crash; I imagine reproducing it is difficult.

from store.js.

IE8 uses localStorage http://msdn.microsoft.com/en-us/library/cc197062(VS.85).aspx You patch would not solve the issue

Seems like others have seen the same issue: http://osdir.com/ml/javascript-information/2009-11/msg00002.html

Before patching the code it would be nice if we have some data indicating that it fixes the issue. For example, if you can sometimes repro the crash in your browser before your patch, and can never repro the crash in your browser after your patch, then that is a good data point.

from store.js.

Yep, I agree, I'm just in a rush, so forked my hacky way for now. :-)

from store.js.

Closing since it's been a while. Feel free to repoen if relevant.

from store.js.