Comments (7)
This is implicitly added via DotNet.ReproducibleBuilds. And DotNet.ReproducibleBuilds is a developer dependency (see the PrivateAssets entry of PackageReference Include only for you, the user has no additional dependencies:
<PackageReference Include="DotNet.ReproducibleBuilds" Version="1.1.1" PrivateAssets="All"/>
You only have pros like able to step into code, only small con is a little larger package size as the PDB data with the sourcelink JSON are embedded in the DLL.
from asynckeyedlock.
I will look into the implications of this.
As cons I see adding a dependency for everyone, larger package sizes and I'm not sure if there's any effect at all on performance (do you?)
The pros need to outweigh the cons. Why are you stepping into the source code, do you have an actual problem?
from asynckeyedlock.
I've stumbled upon this, would this work for you?
https://github.com/dotnet/sourcelink
from asynckeyedlock.
Will performance be affected in any way?
from asynckeyedlock.
Are you interested in creating a PR for this so I could create a pre-release version and benchmark performance?
from asynckeyedlock.
Done with #9 :
File size of package is only a bit larger
And when you turn off "Just my code" in VS debug options and try to step into you need to accept the warning
you can step into the code magically
from asynckeyedlock.
Brilliant, thank you!
I released 6.1.1-beta and it's currently being benchmarked against 6.1.0 at https://github.com/MarkCiliaVincenti/AsyncKeyedLockBenchmarks/actions/runs/4025314083/jobs/6918371621
from asynckeyedlock.
Related Issues (8)
- Can i use this library for these use cases? HOT 3
- NullReferenceException when accessing from Dependency Injection using Azure Functions HOT 4
- Question: What am I missing here? HOT 5
- New builds? HOT 2
- ArgumentOufOfRangeException although passed value is valid HOT 2
- Race condition in the AsyncKeyedLockDictionary<TKey> class HOT 24
- Update TargetFrameworks (remove 5.0, add 6.0 and 7.0) HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from asynckeyedlock.