Giter VIP home page Giter VIP logo

Comments (3)

markerikson avatar markerikson commented on May 21, 2024

Hmm. This sounds odd at a couple levels.

If you look at the commit logs, b55dbd5 adds the scripts to create the Cesium DLL bundle, but doesn't actually modify the app build process to make use of that bundle. Commit 6db616f then actually modifies the app build config to reference the DLL bundle.

In theory, checking out b55dbd5 and running npm run build:dll:cesium should result in a distdll folder being created, with (I think) two files: cesiumDll.js (which should be about 2MB, minified), and cesiumDll-manifest.json. On my box, that step takes about 35 seconds to execute. I do have Webpack's logging configured to turn off much of the noise, but it should display the names and sizes of those two files when it's done.

If you've only got b55dbd5 checked out, then I would expect that running npm run build would succeed, because it shouldn't yet be trying to make use of the DLL bundle.

Out of curiosity, if you check out 67e831e , do the Cesium bundle and overall build steps work there?

It's certainly possible I missed something when assembling these commits. I don't have time at the moment to look into this myself, but please let me know what happens.

from cesium-react-webpack-demo.

bellentuck avatar bellentuck commented on May 21, 2024

Thanks so much!

In checking out 67e831e, I noticed two small discrepancies:

  1. My config/paths.js for some reason did not include the "ownNodeModules" line
  2. Silly mistake - I never exported webpackConfig at the end of config/webpack.cesium.dll.config.js! (This last line had been cut off in the image of this file that is featured in your blog post for the demo.)

After adding those two lines, both npm run build:dll:cesium and node scripts/build.js worked as expected.

Does this mean I can get rid of that $PROJECT/build folder now?

Thanks again!!

from cesium-react-webpack-demo.

markerikson avatar markerikson commented on May 21, 2024

The build folder should be created every time you run CRA's npm run build command, and will include all the normal JS app bundle output. The changes in 902ba04 should update things so that the build output also includes the Cesium DLL bundle and the rest of the needed Cesium folder contents.

Looking at the blog post... yeah, my bundle config snippet does leave out the export line. (It's an actual syntax-highlighted snippet, not an image.) Thanks for pointing that out, I'll fix it when I get a chance.

Glad to hear it's working for you! Just out of curiosity, what's your use case and background for learning this? Are you actually planning to use Cesium for something, or just curious about the build process aspect?

from cesium-react-webpack-demo.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.