Comments (3)
thank you for using whaaaaat and for submitting issues and PRs. I am traveling right now and I can not promise to take a look before the weekend. First impression of your PRs is great so I assume they pass the tests, too.
BTW, please be aware that prompt_toolkit is undergoing major changes right now so this might significantly impact whaaaaat in the future.
from whaaaaat.
thank you for writing and sharing the software! Sorry, but I have to withdraw the PRs again, looks like I got a little bit confused when creating the branches. Since I had to modify the same line for two fixes, the PRs include each other changes... I'm going to clean that up a little bit and then I'll resubmit the PR(s). Going to try the tests as well, however it looks like the're not working in my OS X environment...
I also fixed another issue, going to report it and submit the PR as well. Sorry for the confusion.
Hope you will find time to include the fixes at the weekend!
Thanks and regards
Daniel
from whaaaaat.
I re-submitted the PRs, now with correct content. I had to submit a combined PR for issues #9, #10 and #11, since the commits modify the same lines of code, thus this should avoid merge conflicts.
from whaaaaat.
Related Issues (17)
- Checkbox: inverting ignores disabled entries and selects them even though they are disabled
- Checkbox: when the first item is disabled, it is still selected as default selection
- pip install out of date HOT 1
- Dynamic Question Mark HOT 1
- Offer to join the contributer's team HOT 1
- Incompatible with prompt_toolkit version 2.0 HOT 12
- List: redundant line spaces before the list get printed HOT 1
- List question: Choices jump down to window bottom
- Looking for a maintainer? HOT 4
- ImportError: cannot import name 'Token' from prompt_toolkit.token HOT 2
- Undefined variable HOT 6
- Support for autocomplete?
- Return list of selected items
- Support for new lines and tabs HOT 2
- default function HOT 2
- Checkbox script is using the name as argument when selecting a field even if a value is provided
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from whaaaaat.