Giter VIP home page Giter VIP logo

Comments (3)

markfink avatar markfink commented on July 16, 2024

thank you for using whaaaaat and for submitting issues and PRs. I am traveling right now and I can not promise to take a look before the weekend. First impression of your PRs is great so I assume they pass the tests, too.
BTW, please be aware that prompt_toolkit is undergoing major changes right now so this might significantly impact whaaaaat in the future.

from whaaaaat.

waza-ari avatar waza-ari commented on July 16, 2024

thank you for writing and sharing the software! Sorry, but I have to withdraw the PRs again, looks like I got a little bit confused when creating the branches. Since I had to modify the same line for two fixes, the PRs include each other changes... I'm going to clean that up a little bit and then I'll resubmit the PR(s). Going to try the tests as well, however it looks like the're not working in my OS X environment...

I also fixed another issue, going to report it and submit the PR as well. Sorry for the confusion.

Hope you will find time to include the fixes at the weekend!

Thanks and regards
Daniel

from whaaaaat.

waza-ari avatar waza-ari commented on July 16, 2024

I re-submitted the PRs, now with correct content. I had to submit a combined PR for issues #9, #10 and #11, since the commits modify the same lines of code, thus this should avoid merge conflicts.

from whaaaaat.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.