Giter VIP home page Giter VIP logo

Comments (7)

marklister avatar marklister commented on June 22, 2024

The rfc says

The pad character "=" is typically percent-encoded when used in an
   URI [9], but if the data length is known implicitly, this can be
   avoided by skipping the padding; see section 3.2.

Just thinking out loud here.

from base64.

ochrons avatar ochrons commented on June 22, 2024

Yes, currently I need to run the base64 result through URL escaping to make that happen. But since the code already has special version of b64 for URLs (to avoid escaping), this shoud be part of that feature.

from base64.

marklister avatar marklister commented on June 22, 2024

Sounds reasonable, so if I pad with %3D that should do the trick? And I guess I should do the same for decoding?

from base64.

ochrons avatar ochrons commented on June 22, 2024

Or since you're not following official base64 encoding anyway, just choose a character that is compatible with URL like .

from base64.

marklister avatar marklister commented on June 22, 2024

I've pushed to master, can you have a look and see what you think?

scala> implicit val e= Base64.base64Url
e: com.github.marklister.base64.Base64.B64Scheme = B64Scheme([C@5b590f33,false,<function1>,<function1>)

scala> "abc".getBytes.toBase64
res0: String = YWJj

scala> "abcd".getBytes.toBase64
res1: String = YWJjZA%3D%3D

scala> res1.toByteArray.map(_.toChar)
res2: Array[Char] = Array(a, b, c, d)

I've tried to follow the RFC as closely as possible. Where have I tripped up?

from base64.

ochrons avatar ochrons commented on June 22, 2024

LGTM

from base64.

marklister avatar marklister commented on June 22, 2024

v0.2.2 pushed to maven central. Thanks @ochrons for the input!

from base64.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.