Giter VIP home page Giter VIP logo

Comments (3)

pedramphp avatar pedramphp commented on June 16, 2024

this is how we used to do with backbone, I guess marko widgets is missing to remove the this reference it self.

destroy: function(){
            //COMPLETELY UNBIND THE VIEW
            this.undelegateEvents();
            this.$el.removeData().unbind(); 

            //Remove view from DOM
            this.remove();  
            Backbone.View.prototype.remove.call(this);
        }

from marko-widgets.

patrick-steele-idem avatar patrick-steele-idem commented on June 16, 2024

There is not enough information to act on this issue. In the marko-widgets@>3.0 we dropped the this.widgets collection so no cleanup is required. In the marko-widgets@<3.0 we do remove widgets out of the this.widgets collection using the following code:
https://github.com/raptorjs/marko-widgets/blob/5658cae45a85ccc5bbae4849c09a847bd687f392/lib/Widget.js#L59-L64

Can you please provide more details?

from marko-widgets.

patrick-steele-idem avatar patrick-steele-idem commented on June 16, 2024

Doing some house cleaning. If this is still an issue please let me know, but I'm going to go ahead and close it.

from marko-widgets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.