Adding custom Calendar properties is not possible without code duplication about ical HOT 4 CLOSED

This is released in 2.11.0:

class MyCalendarFactory extends CalendarFactory
{
  protected function getProperties(Calendar $calendar): Generator
  {
      yield from parent::getProperties($calendar);

      // Additional custom properties:
      yield new Property('X-WR-CALNAME', new TextValue('MyValue'));
  }
}

from ical.

The changes that you suggest makes sense in my opinion.

Is there a reason why the getProperties method is declared private instead of protected?

The main reason is, that private is always the default, when I create classes. For the EventFactory that already changed, so yes, it makes sense to change this for the CalendarFactory as well.

from ical.

I would like to add some custom extensions from https://en.wikipedia.org/wiki/ICalendar#Calendar_extensions and found this issue. Would it be possible to make getProperties() protected, as suggested, or implement custom extension adding functionality? Thanks!

from ical.

Indeed it is, thanks @markuspoerschke !

from ical.