Giter VIP home page Giter VIP logo

Comments (7)

jongwook avatar jongwook commented on May 30, 2024 1

@adarob @justinsalamon Thanks for the heads up! Just pushed v0.0.11 :)

Btw you can use:

git+https://github.com/marl/crepe.git

in requirements.txt to pull the latest commit from Github, or:

git+https://github.com/marl/crepe.git@7f0bf0593847f38df47d2760934d585ad2f618c0

for a specific commit.

from crepe.

jongwook avatar jongwook commented on May 30, 2024

Thank you for the detailed report! This is a great catch, and it's striking that the code works regardless.

I'll push the fix shortly.

from crepe.

angusturner avatar angusturner commented on May 30, 2024

Just a quick question, was the model trained on audio normalized the old / incorrect way?

I am using a PyTorch port of this repo with your weights, and am wondering whether I should change or update the normalization code? Or if the model requires re-training with the fixed normalization?

from crepe.

jongwook avatar jongwook commented on May 30, 2024

The pre-processing code I used for training is different from this, which did not have the normalization bug in this issue. So it shouldn't require retraining and you can use the same pre-trained model, unless you want to fine-tune the model with some other dataset.

from crepe.

adarob avatar adarob commented on May 30, 2024

@jongwook will you be releasing an updated pip package with this fix?

from crepe.

justinsalamon avatar justinsalamon commented on May 30, 2024

Yes :) @jongwook let me know if you're slammed right now and I can make a release. Cheers!

from crepe.

HudsonHuang avatar HudsonHuang commented on May 30, 2024

Just a quick question, was the model trained on audio normalized the old / incorrect way?

I am using a PyTorch port of this repo with your weights, and am wondering whether I should change or update the normalization code? Or if the model requires re-training with the fixed normalization?

@angusturner
Hi, Iā€˜m looking for the pytorch version of CREPE, but found nothing. Does the "PyTorch port" you mentioned is public available? or would you mind about releasing it? Thank you very much in advance.

from crepe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.