Comments (4)
using matplotlib
for pixel-perfect drawing was a little pain, dealing with dpi
and figimage()
because with pyplot.imshow
it's even more difficult to deal with the margins.
I don't see using deprecated scipy.misc.imsave
as an immediate problem, as long as we freeze the dependency. If it bugs you, I'd prefer using imageio
as suggested by the doc, rather than pyplot
.
matplotlib
dependency is also not a huge problem as most of our audience would have it installed anyway, but it bugs me a little bit in the pure software engineering perspective, because the only thing that we're using is the inferno
colormap. Those are linear colormaps and can be reimplemented with < 10 lines of code.
from crepe.
I think we should definitely avoid using deprecated modules in a new release, especially since it's been deprecated since 1.0.0.
I don't see the point of importing both matplotlib AND imageio, we should just use one. I'm not sure I follow what you mean by "pitch perfect drawing"? Anyway, I'm happy for us to switch to imageio if you prefer... we just need to decide.
from crepe.
I meant to type pixel-perfect.. but anyway, let's do imageio
for saving images, and we can save grayscale images instead of inferno for the time being.
from crepe.
Replaced scipy.misc.imsave with imageio.imwrite in 592e493
from crepe.
Related Issues (20)
- CREPE incompatible with latest TF HOT 6
- hop size rounding errors might accumulate
- ---delete
- CREPE model Tensorflow on Android HOT 4
- Can you provide these 6 training data?
- Monterey HOT 1
- performance on MIK-1K HOT 2
- Re-training for alternate samplerate HOT 2
- I ran into an error when I install crepe HOT 1
- Fail to install crepe
- update PYPI package to work with hmmlearn==0.2.8 and viterbi=True HOT 1
- Permute layer HOT 2
- Poor confidence issue
- Maximum real-time speed of the model HOT 1
- Pitch estimation for 44.1kHz audio
- AttributeError: type object 'Distribution' has no attribute '_finalize_feature_opts'
- Where does 1997.3794084376191 come from?
- SSL Error when installing crepe HOT 13
- preprocessing implementation in other languages
- Support `hmmlearn==0.3.0` for M1 Mac HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from crepe.