Giter VIP home page Giter VIP logo

Comments (7)

bmcfee avatar bmcfee commented on August 22, 2024

I think we don't have this already because pitch contour namespace semantics assume a dense (instantaneous) sampling, which assumes a frame rate. The midi namespaces are intervalic, so we would have to assume a sampling rate to make this work, and I want all automatic conversions to be parameter-free.

from jams.

tomxi avatar tomxi commented on August 22, 2024

I was able to convert 'pitch_midi' annotations to 'pitch_contour' though, and the conversion 'pitch_contour' is not 'dense'. See picture:
screen shot 2018-01-17 at 11 52 24 am

Right now I'm saving all my note annotations in 'pitch_midi' namespace even though it's deprecated, only because 'pitch_midi' can be converted to 'pitch_contour' and 'note_midi' can't

from jams.

bmcfee avatar bmcfee commented on August 22, 2024

Hrm. This seems like a bug then -- maybe held over from when we revamped the pitch namespaces. Maybe this conversion should be removed.

@rabitt @justinsalamon what do yall think?

from jams.

tomxi avatar tomxi commented on August 22, 2024

If it counts for anything at all: personally I'm for these conversions, because they facilitate eval between note_midi type annotations and dense annotations like pitch_contour.

Right now all my reference annotations are namespace = 'pitch_midi' and I have pitch_contour estimation... It would be really nice if jams.eval can work on these sort of evaluations without too much work on my part.

from jams.

bmcfee avatar bmcfee commented on August 22, 2024

@tomxi one of the fun things about the jams library is that you can extend it / monkey-patch it to do that sort of thing at run-time. If you have a non-standard conversion that you want to automate syntactically, you can just write it and register it using the decortator in nsconvert, and it doesn't need to live in the jams library. (See for example) I've done this sort of thing before for custom tag namespaces, and it's not too hard to do.

That might be a reasonable compromise if we can't work out a lossless or assumption-free converter that would make sense to include in the main library.

from jams.

tomxi avatar tomxi commented on August 22, 2024

That sounds like a pretty good solution going forward for my use-case. Thanks for the tip @bmcfee :)

from jams.

bmcfee avatar bmcfee commented on August 22, 2024

I think we can call this one resolved.

from jams.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.