Docco or Code issue with Z_MIN_PROBE_ENDSTOP about marlindocumentation HOT 8 CLOSED

#define Z_MIN_PROBE_PIN Z_MAX_PIN was removed from Configuration.h because it doesn't work. It results in the Z_MIN_PROBE_PIN not having a value. That results in the "interrupt-capable" test not being applied to the Z_MIN_PROBE_PIN. Strange stuff happens at compile time.

#define Z_MIN_PROBE_PIN 18 in either Configuration.h or in the pins_YOUR_BOARD.h file works as expected.

As best I can tell, you are correct that there is NOT a default for the Z_MIN_PROBE_PIN. I can't find one in the code and you get a sanity check error when Z_MIN_PROBE_ENDSTOP is enabled but Z_MIN_PROBE_PIN isn't specified.

I'll start a PR to correct the defaults to Z_MAX statement in the Configuration.h files.

from marlindocumentation.

Definitely past my bed time.

The offending statement is in the probes document on the Wiki.

from marlindocumentation.

It's late for me too, but I think you are describing what happens if Z_MIN_ENDSTOP is not defined.

I spent a whole afternoon looking at this, and there is a default. In some situations. The trouble is the other X (re)definitions in some unknown hierarchy screwing with what I declared.

from marlindocumentation.

screwing with what I declared

If you can provide examples of this I can investigate & see if there is a reasonable explanation.

from marlindocumentation.

PR #86 has been created to delete the Z-MAX default line.

from marlindocumentation.

As I said: Despite the semi-policy of limiting the words in the source, I think it would be kind to mention Z_MIN_ENDSTOP in that comment.

I did see evidence that something tries to use the z-max pin, but it was obviously from some time ago, because there is a lot of other conflicting code now.

As for redefining things; there's a bunch of stuff related to the bl-touch somewhere obtuse, a bunch in conditional_lcd.h, pins_xxx.h does it too.

I'll raise a separate issue if you think it's worth it.

from marlindocumentation.

I know all about the BLTouch defines. We did it that way to make life simpler for the users which also makes supporting Marlin a lot easier. Unless there's an error or an unusual situation we'll leave them alone.

from marlindocumentation.

Sweet. I was just pointing out some things that caused me pain or looked odd to me.

from marlindocumentation.