"No such keymap 'menuselect'" errors when using prezto/editor module about zsh-snap HOT 6 CLOSED

Fixed.

from zsh-snap.

This is not a bug in zsh-autocomplete, but actually an incompatibility between Prezto and Znap. I should be able to fix it, though.

from zsh-snap.

Thanks for this. However I feel like this is too much of a hack.

• This fix is specifically for people who use znap. If they don't then they will still encounter this problem.

• Would it be easier if you just check if the menuselect keymap exists? If not just recreate it. I'm not too familiar with how zsh works so that might be an invalid idea.

from zsh-snap.

@marlonrichert I think I've made this bug report in the wrong place. This shouldn't be the job for a plugin manager.

How about we revert this and I will create an issue in zsh-autocomplete? Maybe I'll even do a PR.

Sorry for the trouble.

from zsh-snap.

@patrickli

This fix is specifically for people who use znap. If they don't then they will still encounter this problem.

No, they won’t. I tested it and the bug doesn’t occur without Znap.

I think I've made this bug report in the wrong place. This shouldn't be the job for a plugin manager.

You filed this bug report against zsh-autocomplete, but I transferred it to the Znap repo, because of the reason above.

Would it be easier if you just check if the menuselect keymap exists? If not just recreate it. I'm not too familiar with how zsh works so that might be an invalid idea.

No, that wouldn’t work. Zsh doesn’t let you run a module more than once. What I’m doing instead is to run the complist module on demand when any code tries to modify the menuselect keymap. That was already the intention of the old code; I’m just doing it a bit more smartly now.

How about we revert this and I will create an issue in zsh-autocomplete? Maybe I'll even do a PR.

The problem does not lie in zsh-autocomplete. The problem is that Znap calls zmodload zsh/complist, which (among other things) initializes the menuselect keymap, but then Prezto calls bindkey -d, which resets all keymaps to default state and deletes all non-default keymaps.

I fixed it by making it so that complist gets called only when any code actually tries to use the menuselect keymap (instead of calling it the first time bindkey gets called).

from zsh-snap.

OK understood. Thanks for the explanation.

from zsh-snap.