TypeScript types are generated with unsafe types because strictNullChecks is false about react-admin HOT 5 CLOSED

Here is the process I suggest:

1. Turn on strickNullChecks in your checkout
2. Try to compile the core
3. Choose a part of the library (auth, forms, etc)
4. Fix a reasonable amount of errors to make the change readable
5. Turn off strickNullChecks
6. Open a PR with your changes.

This way, we can gradually make the types better. It will take several PRs to fix the core. This improvement will only be made available for users once we have all the checks fixed. But that's the only safe way.

from react-admin.

Hi, and thanks for your report.

We're well aware of the limitations caused by structNullChecks=false in the quality of types. We have it on our radar, but the benefit / cost ratio of this task is low, so it's not a priority for us. Fixing it is non-trivial, as we have to make ra-core compilable with strict?NullChecks=true. Previous attempts (#8141) lead to a dead end.

You're welcome to contribute small PRs fixing types of individual hooks & components for strict null checks.

I'm closing this issue as it's a long-term goal.

from react-admin.

Thanks for letting us know it's a long term goal. It's not possible to fix the issue with the hooks until strictNullChecks is enabled. It's currently not possible to use the generated types safely in projects.

from react-admin.

@fzaninotto What sort of approach would be required to get strictNullChecks enabled? It looks like someone tried to help you with it in #8141, but because the scope of the change was too big the PR was closed.

I'm not sure how you could partially add strict null checks to make for a smaller PR that would be accepted.

The benefit is quite high for people using React Admin as it will catch a lot of runtime errors at compile time.

from react-admin.

Here is an exemple small PR fixing the ra-core types: #9644

from react-admin.