Giter VIP home page Giter VIP logo

Comments (4)

bguidolim avatar bguidolim commented on May 27, 2024 1

Got it. Well, PNK relies on the metadata provided by libPhoneNumber from Google, and the number provided is considered valid on that lib.
You might need to report this issue there.

from phonenumberkit.

bguidolim avatar bguidolim commented on May 27, 2024

I didn’t the issue.

from phonenumberkit.

sharukmsd avatar sharukmsd commented on May 27, 2024

valid numbers for pakistan start with 3******* or +923*******, not with 5*******

I didn’t the issue.

from phonenumberkit.

sharukmsd avatar sharukmsd commented on May 27, 2024

Following code resolves the issue, thanks for the help @bguidolim

    func validateNumberLengthAndFormat(_ number: String) -> Bool {
        let nonFormattedNumber = number.replacingOccurrences(of: " ", with: "")
        if nonFormattedNumber.count >= validNumberLength {
            let numberToFormat = String(nonFormattedNumber.prefix(validNumberLength))
            let formattedNumber = phoneNumberValidaor.formatNumber(numberToFormat, forRegion: selectedCounrty.regionId)
            if formattedNumber != phoneNumberInput {
                phoneNumberInput = formattedNumber
                return phoneNumberValidaor.isValidPhoneNumber(phoneNumberInput, forRegion: selectedCounrty.regionId)
            }
        }
        return false
    }

and here's PhoneNumberValidator

class PhoneNumberValidator {
    
    let phoneNumberKit = PhoneNumberKit()
    
    func isValidPhoneNumber(_ number: String, forRegion regionId: String) -> Bool {
        return phoneNumberKit.isValidPhoneNumber(number, withRegion: regionId)
    }
    
    func formatNumber(_ number: String, forRegion regionId: String) -> String {
        let phoneNumber = try? phoneNumberKit.parse(number, withRegion: regionId)
        guard let phoneNumber = phoneNumber else {
            return number
        }
        let formattedNumber = phoneNumberKit.format(
            phoneNumber, toType: .national, withPrefix: false)
            .replacingOccurrences(of: "^0+", with: "", options: .regularExpression
        )
        return formattedNumber
    }
    
}

from phonenumberkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.