Giter VIP home page Giter VIP logo

Comments (4)

boring-cyborg avatar boring-cyborg commented on September 14, 2024

Thanks for opening your first issue in the Marquez project! Please be sure to follow the issue template!

from marquez.

phixMe avatar phixMe commented on September 14, 2024

Can you dig into the root cause of this a little for us and evaluate our conditional logic along with the OpenLineage events that you have defined?

The logic we have for this lies here:
https://github.com/MarquezProject/marquez/blob/main/web/src/routes/datasets/Datasets.tsx#L219-L230

from marquez.

namyyys avatar namyyys commented on September 14, 2024

I tried to dig into the root cause a little bit. From my analysis i think it's coming from this function
I encounter this issue with a dataset, for example, which has 34 assertions (32 passing and 2 failing). In the logic i see from the above function, the color of the quality is only tested on a subset of all the assertions (the last 14 i believe). We think that the 2 failing cases are not included in this subset and thus the coloring is wrong.

from marquez.

phixMe avatar phixMe commented on September 14, 2024

Yes, thanks, I just submitted a PR to rectify this.

from marquez.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.