Giter VIP home page Giter VIP logo

Comments (6)

jyrkive avatar jyrkive commented on May 28, 2024 1

Yes, I can confirm that it works on my system (with Corsair K95 RGB Platinum keyboard). 👍

from retc.

MartB avatar MartB commented on May 28, 2024

Iirc this is an razer api thing, if the effect guid is set inside playEffect we are supposed to only save the effect for this guid and not play it until it gets requested later (by SetEffect).

This is how the official razer keyboard api test program expects things to work atleast.

from retc.

MartB avatar MartB commented on May 28, 2024

Regardless is there any sample that doesnt work like this?

from retc.

jyrkive avatar jyrkive commented on May 28, 2024

Yeah, the Vivaldi web browser that just got Razer Chroma integration in the latest update.

Interesting to hear that apparently it's Vivaldi that uses the API incorrectly...

from retc.

MartB avatar MartB commented on May 28, 2024

Vivaldi uses the api in the following way,

CreateKeyboardEffect type, CHROMA_STATIC (4) guid: 0x008feb04 {0F9B4E2F-9F4A-0C9B-BD7E-5D4B85BD8C5E}
CreateKeyboardEffect type, CHROMA_STATIC (4) guid: 0x008feb04 {9BA1C0EF-D917-454C-9E9A-46E4AB337824}
CreateKeyboardEffect type, CHROMA_STATIC (4) guid: 0x008feb04 {723F73D8-6FB8-4176-94F4-34C70A82B5E4}
CreateKeyboardEffect type, CHROMA_STATIC (4) guid: 0x008feb04 {6AB75F46-E39A-4F46-95AE-058025C0E5F6}
CreateKeyboardEffect type, CHROMA_STATIC (4) guid: 0x008feb04 {7E82C073-3798-466C-914E-1C4C68FFFCC1}
CreateKeyboardEffect type, CHROMA_STATIC (4) guid: 0x008feb04 {4E9A88A1-CD96-4A39-BCC0-F1A159F41957}
CreateKeyboardEffect type, CHROMA_STATIC (4) guid: 0x008feb04 {E30FFAA1-2F67-482C-A30E-438CD557AD2D}
CreateKeyboardEffect type, CHROMA_STATIC (4) guid: 0x008feb04 {8D354EE2-9FCE-40CC-A04B-8D20B9E6A4DA}
CreateKeyboardEffect type, CHROMA_STATIC (4) guid: 0x008feb04 {2B770EC5-76E5-47F1-9A23-A8B9D89ABC31}
CreateKeyboardEffect type, CHROMA_STATIC (4) guid: 0x008feb04 {7E3E4C46-DBE0-4A4C-937D-3A15C75B5CEC}
CreateKeyboardEffect type, CHROMA_STATIC (4) guid: 0x008feb04 {0F9B4E2F-A12F-E7E9-ADE6-6343BD3D5433}
CreateKeyboardEffect type, CHROMA_STATIC (4) guid: 0x008feb04 {2E16CC2F-CC24-418F-AB87-1A7C286A4D81}
CreateKeyboardEffect type, CHROMA_STATIC (4) guid: 0x008feb04 {ADC43B28-88E2-49A3-A00C-AB99FEE1B334}
CreateKeyboardEffect type, CHROMA_STATIC (4) guid: 0x008feb04 {3BDD43FA-FFE4-43D5-96F3-D593A252E847}
CreateKeyboardEffect type, CHROMA_STATIC (4) guid: 0x008feb04 {7483DDCC-D3FE-4576-A215-9697BEA5BEF7}
CreateKeyboardEffect type, CHROMA_STATIC (4) guid: 0x008feb04 {80CDF540-144E-4301-AC8B-315023DDEE97}
CreateKeyboardEffect type, CHROMA_STATIC (4) guid: 0x008feb04 {F1EBBF3E-1763-48D8-864C-7A7DA9AD5128}
CreateKeyboardEffect type, CHROMA_STATIC (4) guid: 0x008feb04 {2913E69F-5022-4EF3-9BD0-A15B5E7FD2AC}
CreateKeyboardEffect type, CHROMA_STATIC (4) guid: 0x008feb04 {27B8FA33-7BDA-46A3-A7D6-768C5A93B181}
CreateKeyboardEffect type, CHROMA_STATIC (4) guid: 0x008feb04 {B2594F61-7135-47D7-A025-4BDF31BF6503}

The guid does not exist in our effect store though, so im not quite sure what to do with it, as the razer api docs lack any sort of documentation for whats supposed to happen if a non null guid is passed to CreateKeyboardEffect.

The sample on razers page does it different (correct?!) https://assets.razerzone.com/dev_portal/docs/_chroma_s_d_k_impl_8cpp-example.html
It does save the effects supplying a 0-Guid and expects them to get saved instead of played.

From my point of view, it looks like Razer is failing gracefully in vivaldis case, or i am missing an important decision in razers api code.

A fix for this could look sth like this:

// We got a valid effectID, pointer
if (pEffectId != nullptr) {
	const auto guid = *pEffectId;
	// The user supplied a NULL guid, try to give him a new valid one and store the effect.
	if (guid == GUID_NULL) {
		return m_effectManager->storeEffect(devType, effectType, pEffectId, size, effectData) ? RZRESULT_SUCCESS : RZRESULT_FAILED;
	}

	// [API Not clear] The Effect might exist already, as the supplied guid was not null, if not playback directly
	// Note: This could also be only playbackEffect, but at this stage im not sure.
	return setEffect(guid) != RZRESULT_NOT_FOUND || playbackEffect(devType, effectType, effectData);
}

However im not sure if the setEffect branch is valid or only playbackEffect should be used here.

from retc.

MartB avatar MartB commented on May 28, 2024

I went ahead and prepared a test setup for you, which should theoretically work
Its based on 27a64e9

RETC_Setup.zip

Can you report back if everything works correctly for you?

from retc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.