[card.idCopy] In game copy-id of cards about clash-royale-api HOT 16 CLOSED

I will try to add the card ids this week, I'm currently super busy right now, so if you like you can add it on each card in the data generator as copyId and I'll update the API to support it, that way you could help A LOT!

from clash-royale-api.

I support this, I think it can be very beneficial.
is there's an official source of mentioned id? something we can rely on for future cards and double checking?

from clash-royale-api.

no worries, done!

from clash-royale-api.

Thanks @TorzuoliH!

I will be working on this enhancement this week and I'll let you know when it is ready.

from clash-royale-api.

Added copyId on each card.

Please if there is a wrong ID or something let me know as soon as possible.

from clash-royale-api.

If this is going to be added, I'd suggest naming this property idCopy because it is the id that used in copy link 😉

@MaherFa what do you think?

from clash-royale-api.

@MaherFa No I couldn't find an official source, all I could find was a reddit post :P

But I provided the list and for all current cards, we can just use the game and try to share a deck with the new card and it'll be revealed :)

I don't mind this key to have null for new cards.

from clash-royale-api.

good enough if you're willing to test all of them!
and btw, this issue is a duplicate of (#92)

from clash-royale-api.

Wow, didn't know about the duplicate, this issue can be closed but the list I provided should be mentioned so it's easier to add them when implementing the issue.

from clash-royale-api.

@MaherFa although, I didn't get my list from reddit, I got em from a live website using them, you could say I stole them :D but I use them for my website too, so if there's an issue with em (like incorrect id) I will know about it, so far no issue.

from clash-royale-api.

@martincarrera I tried to do so, but I couldn't figure out how to :( but I'll try again :D

from clash-royale-api.

I will do this soon @AmirSavand

from clash-royale-api.

@TorzuoliH I just figured out, I didn't know they were on https://github.com/martincarrera/clash-royale-api-data-generator

Anyway, cool thanks.

from clash-royale-api.

Sorry for being late: here's the work : martincarrera/clash-royale-api-data-generator#18

from clash-royale-api.

Ok nice 😄

Maybe if you could merge Barbarian Barrel request (on the other repo), I will see for adding the missing ids.

from clash-royale-api.

@martincarrera wooo! nice work.

from clash-royale-api.