Giter VIP home page Giter VIP logo

Comments (3)

martinjw avatar martinjw commented on August 27, 2024

Fixed in 2.12. Thanks!

from holiday.

sergiu05 avatar sergiu05 commented on August 27, 2024

Hello,
Thanks for your fast update.
Small observation:

public static DateTime? LiberationDay(int year)
       {
           if (year < 1990 && year % 5 == 0)
           {
               return new DateTime(year, 5, 5);
           }

           return new DateTime(year, 5, 5);
       }

This will return a DateTime value for all years less than 1990, because the execution flow will reach the second return statement for the years smaller than 1990 non-divisible by 5 (e.g. 1989, 1988).

An updated version:

public static DateTime? LiberationDay(int year)
        {
            if (year >= 1990)
            {
                return new DateTime(year, 5, 5);
            }
            else if (year >= 1945)
            {
                if (year % 5 == 0)
                {
                    return new DateTime(year, 5, 5);
                }
            }
           return null;
        }

Could you have a look?
Thanks again,
S.

from holiday.

martinjw avatar martinjw commented on August 27, 2024

Thanks @sergiu05 - updated. I won't do an immediate nuget release - I don't think many people will be looking up calendars that old!

from holiday.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.