Giter VIP home page Giter VIP logo

Comments (4)

martinjw avatar martinjw commented on July 24, 2024
  • Also New Zealand.
  • Also technically Canada, but it is named Victoria Day (thanks Canada for not keeping up to date)

Perhaps MonachsDay or SovereignDay? Or just change to KingsDay? Or dynamically change the holiday name (year>=2023? "KingsDay" : "QueensDay" )?

Any preferences?

from holiday.

dotnetshadow avatar dotnetshadow commented on July 24, 2024

I like the idea of MonachsDay but perhaps allow for the name to change every time there is a new King/Queen?
i.e. "Queen's Birthday" | "King's Birthday" but associate the enum to MonachsDay?

from holiday.

martinjw avatar martinjw commented on July 24, 2024

https://github.com/martinjw/Holiday/releases/tag/2.26.0.0

from holiday.

dotnetshadow avatar dotnetshadow commented on July 24, 2024

Hi there,

I just had a chance to try the library out with the new "king" support but I don't know if it's working

I seem to get only Queens Birthday as the name, am I doing something wrong?
image

from holiday.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.