Could xlf output be better formatted about ngx-i18nsupport HOT 9 CLOSED

@martinroob @martinsik Can't we add a pretty-xml call on the output before writing in the final xlf file ? (@martinroob thanks for your work btw !)

from ngx-i18nsupport.

This should be possible. I will have a look at it

from ngx-i18nsupport.

@martinsik I'm confronted to the same issue. I solve this by apply a little home made js script on the xlf files :

const replace = require('replace-in-file');
const format = require('xmlfmt');
const fs = require('fs');
const xlfFilesPath = 'src/i18n/*.xlf';

// Remove leading and trailing whith space
const filesChanges1 = replace.sync({
  files: xlfFilesPath,
  from: [/^\s*/gm, /\s*$/gm],
  to: ''
});

// Remove \n to put all in 1 line
const filesChanges2 = replace.sync({
  files: xlfFilesPath,
  from: /\n/gm,
  to: ''
});

// Format xml files
[
  'src/i18n/messages.xlf',
  'src/i18n/messages.en.xlf',
  'src/i18n/messages.fr.xlf'
].forEach(file => {
  fs.writeFileSync(file, format(fs.readFileSync(file, 'utf8')));
});

It need replace-in-file and xmlfmt to work.

from ngx-i18nsupport.

Starting with version 0.16.0 there is a new configuration parameter beautifyOutput. When it is set to true now pretty-data (the library beyond pretty-xml) will be used to format the output.

from ngx-i18nsupport.

Hi,
in principle you are absolutely right.
Unfortunately the output is just what the library I use for xml handling (xmldom) gives.
There is no good formatter available at the moment. At least I do not know one.
So I am sorry that I cannot correct this. Maybe later.
Instead of translating manually by editing the ugly xml file you should think about using a translation tool (TinyTranslator is the one I suggest if course)

from ngx-i18nsupport.

@evanliomain I ended up using the following command to prettify the output:

npm i --save-dev pretty-xml

And then the following:

cat src/locale/messages.zh.xlf | node node_modules/.bin/pretty-xml > src/locale/messages.zh.xlf-new && rm src/locale/messages.zh.xlf && mv src/locale/messages.zh.xlf-new src/locale/messages.zh.xlf

from ngx-i18nsupport.

@martinroob Awesome ! Thanks a lot !

from ngx-i18nsupport.

@martinsik I'm confronted to the same issue. I solve this by apply a little home made js script on the xlf files :

const replace = require('replace-in-file');
const format = require('xmlfmt');
const fs = require('fs');
const xlfFilesPath = 'src/i18n/*.xlf';

// Remove leading and trailing whith space
const filesChanges1 = replace.sync({
  files: xlfFilesPath,
  from: [/^\s*/gm, /\s*$/gm],
  to: ''
});

// Remove \n to put all in 1 line
const filesChanges2 = replace.sync({
  files: xlfFilesPath,
  from: /\n/gm,
  to: ''
});

// Format xml files
[
  'src/i18n/messages.xlf',
  'src/i18n/messages.en.xlf',
  'src/i18n/messages.fr.xlf'
].forEach(file => {
  fs.writeFileSync(file, format(fs.readFileSync(file, 'utf8')));
});

It need replace-in-file and xmlfmt to work.

Thanks

from ngx-i18nsupport.

Just here to say that I was totally missed this parameter. At least I found it now. This is gold. I was really frustrating with earlier dirty style how those files looks like. It was really hard to merge files and read them and edit them because there were several translations all in one line. Thank you for this feature.

from ngx-i18nsupport.